Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/googleclientauth] Update github.com/GoogleCloudPlatform/opentelemetry-operations-go v0.48.0 #33493

Merged
merged 9 commits into from
Jun 19, 2024
Merged

[extension/googleclientauth] Update github.com/GoogleCloudPlatform/opentelemetry-operations-go v0.48.0 #33493

merged 9 commits into from
Jun 19, 2024

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 11, 2024

Description:

Update github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension to v0.48.0.

This update includes support for Google-signed ID token.
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.0

Link to tracking Issue:

#33185

Testing:

Documentation:

The documents about googleclientauth extension also updated.

rinx added 2 commits June 11, 2024 22:45
@rinx
chore-deps(googleclientauthextension): update v0.48.0 of
087c9ab 
github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension

Closes: open-telemetry#33185

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
docs(googleclientauthextension): update README
16cc2fc 
Refs: open-telemetry#33185
Signed-off-by: Rintaro Okamura <[email protected]>
@rinx rinx requested review from dashpole and jsuereth as code owners June 11, 2024 13:51
@rinx rinx requested a review from a team June 11, 2024 13:51
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested review from aabmass, damemi, psx95 and punya June 11, 2024 13:53
@dashpole
Copy link
Contributor

cc @damemi @psx95
@psx95 Can you coordinate with @rinx for the update?

xref: #33483

songy23
songy23 reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy, probably make genotelcontribcol too

I guess this needs a changelog too?

@songy23 songy23 added the dependencies Pull requests that update a dependency file label Jun 11, 2024
@psx95
Copy link

psx95 commented Jun 11, 2024

@rinx could you update the tests in this PR as well ?

FYI: the renovate dependency bump PR #33483, also fails due to the outdated tests.

@psx95 psx95 mentioned this pull request Jun 11, 2024
Closed
1 task
@rinx
Copy link
Contributor Author

rinx commented Jun 12, 2024

@psx95 Thanks. I'll try to update the tests.

rinx added 5 commits June 12, 2024 17:08
@rinx
chore-deps(extension/googleclientauth): update go.sum
e170416 
- by `make gotidy`

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
chore-deps(otelcontribcol): update github.com/GoogleCloudPlatform/ope…
19e89cf 
…ntelemetry-operations-go v0.48.0

- by `make genotelcontribcol`

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
test(extension/googleclientauth): fix tests
f61d8b4 
Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
test(extension/googleclientauth): ignore go.opencensus.io/stats/view(…
cb3562e 
…*worker).start in goleak

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
docs: add chlog
f82e506 
Signed-off-by: Rintaro Okamura <[email protected]>
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jun 12, 2024
@rinx
Copy link
Contributor Author

rinx commented Jun 12, 2024

@psx95 Could you please review the changes?

psx95
psx95 reviewed Jun 12, 2024
View reviewed changes
extension/googleclientauthextension/metadata.yaml
@@ -9,3 +9,8 @@ status:

tests:
skip_lifecycle: true
goleak:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the use of metadata.yaml file in this repo, so just confirming - is this required when the generated_package_test.go already programmatically seem to ignore the goleak coming from opencensus ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated_package_test.go is generated based on metadata.yaml. It is required to write goleak.ignore block here.

Without this goleak.ignore, the tests should fail with goroutine leak caused by opencensus.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the confirmation.

psx95
psx95 reviewed Jun 12, 2024
View reviewed changes
Copy link

@psx95 psx95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending one clarification.

PS - Just calling out that the kubernetes test seem to be failing, but I don't see how this PR could cause them to fail.

@rinx
Copy link
Contributor Author

rinx commented Jun 13, 2024 •
edited
Loading

PS - Just calling out that the kubernetes test seem to be failing, but I don't see how this PR could cause them to fail.

I think this is related to #33520.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jun 13, 2024
codeboten
codeboten reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rinx this will need another rebase after the v0.103.0 release. Please wait until the release is out, and rebase the PR to address the conflicts and we can get this merged

codeboten
codeboten reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinx this is ready to rebase whenever you have a moment

@rinx
Copy link
Contributor Author

rinx commented Jun 19, 2024

@codeboten I rebased it. Thanks.

codeboten
codeboten approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rinx

@codeboten codeboten merged commit 44ec1ae into open-telemetry:main Jun 19, 2024
150 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 19, 2024
@codeboten codeboten mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 left review comments

@psx95 psx95 psx95 approved these changes

@dashpole dashpole dashpole approved these changes

@codeboten codeboten codeboten approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@aabmass aabmass Awaiting requested review from aabmass

@damemi damemi Awaiting requested review from damemi

@punya punya Awaiting requested review from punya

Assignees

@dashpole dashpole

Labels
cmd/otelcontribcol otelcontribcol command dependencies Pull requests that update a dependency file extension/googleclientauth ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.104.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rinx @dashpole @psx95 @codeboten @songy23