-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statsdreceiver observability #33415
Merged
dmitryax
merged 2 commits into
open-telemetry:main
from
hardproblems:feature-statsdreceiver-metrics
Jun 11, 2024
Merged
statsdreceiver observability #33415
dmitryax
merged 2 commits into
open-telemetry:main
from
hardproblems:feature-statsdreceiver-metrics
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardproblems
changed the title
Feature statsdreceiver metrics
statsdreceiver observability
Jun 6, 2024
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
from
June 6, 2024 18:02
2375623
to
b00f176
Compare
atoulme
reviewed
Jun 6, 2024
receiver/statsdreceiver/internal/metadata/generated_telemetry_test.go
Outdated
Show resolved
Hide resolved
samiura
approved these changes
Jun 7, 2024
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
3 times, most recently
from
June 10, 2024 17:35
8ad9831
to
a725954
Compare
@samiura would you be able to merge this PR? I'm not authorized to merge. Anything i can do here to get authorized? |
@dmitryax @bryan-aguilar PTAL 🙇 |
jmacd
approved these changes
Jun 10, 2024
gci write --skip-generated -s standard -s default .
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
from
June 11, 2024 17:15
9e68b65
to
0bbf099
Compare
dmitryax
approved these changes
Jun 11, 2024
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector-contrib
that referenced
this pull request
Jun 12, 2024
This reverts commit e5a02fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add received statsd / accepted/refused metrics to statsdreceiver
Resurrecting #31822 since #31839 is closed.
Link to tracking Issue:
#24278
Testing:
This works in our internal testing environments. Took a profile and didn't see metric recording taking much cpu
Documentation:
cc @jmacd @dmitryax @TylerHelmuth