Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource detection processor sets uppercase values in os.type attribute #7522

Closed
dmitryax opened this issue Feb 1, 2022 · 3 comments · Fixed by #7544
Closed

Resource detection processor sets uppercase values in os.type attribute #7522

dmitryax opened this issue Feb 1, 2022 · 3 comments · Fixed by #7544
Assignees
Labels
bug Something isn't working good first issue Good for newcomers processor/resourcedetection Resource detection processor

Comments

@dmitryax
Copy link
Member

dmitryax commented Feb 1, 2022

According to semantic conventions os.type resource attribute has to contain one of the predefined values, all of them are written in lowercase. Resource detection processor sets them in uppercase. It should be changed to lowercase according to semantic conventions

@dmitryax dmitryax added bug Something isn't working processor/resourcedetection Resource detection processor labels Feb 1, 2022
@mx-psi
Copy link
Member

mx-psi commented Feb 2, 2022

Looks like this changed on open-telemetry/opentelemetry-specification#1598

@mx-psi mx-psi added the good first issue Good for newcomers label Feb 2, 2022
@mx-psi
Copy link
Member

mx-psi commented Feb 2, 2022

Also note that ZOS becomes z_os

@mx-psi
Copy link
Member

mx-psi commented Feb 2, 2022

This amounts to changing this function

func GOOSToOSType(goos string) string {
switch goos {
case "dragonfly":
return "DRAGONFLYBSD"
}
return strings.ToUpper(goos)
}
to do the mapping between GOOS and the spec values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers processor/resourcedetection Resource detection processor
Projects
None yet
2 participants