Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to use gopsutil v3 #5510

Closed
7 tasks done
mx-psi opened this issue Sep 29, 2021 · 2 comments · Fixed by #5570
Closed
7 tasks done

Update components to use gopsutil v3 #5510

mx-psi opened this issue Sep 29, 2021 · 2 comments · Fixed by #5570
Assignees
Labels
good first issue Good for newcomers

Comments

@mx-psi
Copy link
Member

mx-psi commented Sep 29, 2021

Several components use gopsutil v2, which is being discontinued (shirou/gopsutil/issues/1078). We should switch them to use version 3 to be able to get security fixes. Currently the components are:

❯ find . -name go.mod | xargs grep -E 'github.com/shirou/gopsutil v3.21.8\+incompatible$' -l | sort
./exporter/signalfxexporter/go.mod
./extension/fluentbitextension/go.mod
./extension/observer/hostobserver/go.mod
./receiver/awscontainerinsightreceiver/go.mod
./receiver/hostmetricsreceiver/go.mod
./receiver/jmxreceiver/go.mod
./testbed/go.mod

To use version 3 import paths should have a /v3 ending (even if using a v3.X.Y.Z tag).

  • Update gopsutil on signalfxexporter
  • Update gopsutil on hostobserver
  • Update gopsutil on fluentbitextension
  • Update gopsutil on awscontainerinsightreceiver
  • Update gopsutil on hostmetricsreceiver
  • Update gopsutil on jmxreceiver
  • Update gopsutil on testbed
@mx-psi mx-psi added the good first issue Good for newcomers label Sep 29, 2021
@mx-psi mx-psi changed the title Update gopsutil to v3 Update components to use gopsutil to v3 Sep 29, 2021
@mx-psi mx-psi changed the title Update components to use gopsutil to v3 Update components to use gopsutil v3 Sep 29, 2021
@mustafain117
Copy link
Contributor

I would like to work on this issue as a first issue, please assign this to me.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 30, 2021

That's great @mustafain117! Assigned to you. I would do a PR for each component (you don't need to do every single one yourself, focus on one at first and continue later if you want to). Here there is more info about the changes between the v2 and v3 of gopsutil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants