Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guide unclear: refers to component_type_tests.go #37914

Open
tigrannajaryan opened this issue Feb 14, 2025 · 2 comments · May be fixed by #37925
Open

Contributing guide unclear: refers to component_type_tests.go #37914

tigrannajaryan opened this issue Feb 14, 2025 · 2 comments · May be fixed by #37925
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tigrannajaryan
Copy link
Member

Component(s)

No response

Describe the issue you're reporting

Adding New Components section says:

The component's tests must also be added as a part of its respective component_type_tests.go file in the cmd/otelcontribcol directory.

There is no component_type_tests.go file in cmd/otelcontribcol directory or anywhere else in the contrib repo. What is this referring to?
@tigrannajaryan tigrannajaryan added the needs triage New item requiring triage label Feb 14, 2025
@atoulme
Copy link
Contributor

atoulme commented Feb 14, 2025

That file was deleted. We should delete that instruction from CONTRIBUTING.md, thanks for reporting.

@atoulme atoulme added help wanted Extra attention is needed good first issue Good for newcomers and removed needs triage New item requiring triage labels Feb 14, 2025
@sonalgaud12
Copy link

Hello @atoulme, I will remove the line, Should I include any instructions, such as "The component must undergo thorough unit and integration testing before being enabled."

@sonalgaud12 sonalgaud12 linked a pull request Feb 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @tigrannajaryan @sonalgaud12