Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sumologicexporter: add carbon formatter #2562

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

sumo-drosiek
Copy link
Member

Description:
Add support for carbon2 format to sumologicexporter

Rebased #2523 after #2543

Link to tracking Issue:
#1498

Testing:
Manual e2e tests, unit tests

Documentation:
Comments

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2562 (d616b80) into main (6566113) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2562   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         431      432    +1     
  Lines       21461    21511   +50     
=======================================
+ Hits        19609    19655   +46     
- Misses       1387     1390    +3     
- Partials      465      466    +1     
Flag Coverage Δ
integration 69.18% <ø> (-0.07%) ⬇️
unit 90.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/sumologicexporter/config.go 100.00% <ø> (ø)
exporter/sumologicexporter/carbon_formatter.go 100.00% <100.00%> (ø)
exporter/sumologicexporter/sender.go 90.41% <100.00%> (+0.23%) ⬆️
...rometheusexecreceiver/subprocessmanager/manager.go 70.00% <0.00%> (-6.00%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6566113...d616b80. Read the comment docs.

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumo-carbon2 branch from e4ebf64 to c04ce53 Compare March 5, 2021 13:16
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumo-carbon2 branch from c04ce53 to d616b80 Compare March 10, 2021 11:03
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect that no other changes were added

@bogdandrutu bogdandrutu merged commit 5efd35d into open-telemetry:main Mar 10, 2021
This was referenced Mar 15, 2021
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Fix TestBackoffRetry in otlp retry pkg

The delay of the retry is within two times a randomization factor (the
back-off time is delay * random number within [1 - factor, 1 + factor].
This means the waitFunc in TestBackoffRetry needs to check the delay is
within an appropriate delta, not equal to configure initial delay.

* Fix delta value

* Fix delta

Co-authored-by: Aaron Clawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants