receiver/dockerstats: add more metrics

[gbbr]

Component(s)

receiver/dockerstats

Is your feature request related to a problem? Please describe.

There are a bunch of metrics available as part of the already used internal/docker package that could be exposed by the dockerstatsreceiver.

Describe the solution you'd like

I would like to open a PR and add the following metrics:

• container.uptime: time.Since(ContainerState.StartedAt) (receiver/dockerstatsreceiver: add container.uptime metric #22851)
• container.cpu.limit: can be computed based on the HostConfig CPU information ([receiver/dockerstats] Add inspect metrics #21803)

Additionally, I would also be interested in adding these:

• container.memory.failcnt: OOM events (data is available in MemoryStats.FailCnt)
• container.memory.working_set: available in MemoryStats.PrivateWorkingSet
• container.memory.commit: available in MemoryStats.Commit
• container.memory.commit_peak: available in MemoryStats.CommitPeak
• container.pid.thread_count: available in PidStats.Current
• container.pid.thread_limit: available in PidStats.Limit
• container.pid.open_files: this one is not available, but we have a small "cgroups" module at Datadog that can help and it'd be easy to obtain the value.

If any of these need more discussion, we can pull them out into their own issue.

[github-actions]

Pinging code owners:

• receiver/dockerstats: @rmfitzpatrick @jamesmoessis

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[jamesmoessis]

Hey @gbbr thanks for your interest in helping improve the docker stats receiver.

Would be happy to review small, decoupled PRs. Probably one for memory, one for PID, and one for "other".

container.cpu.limit already has a PR up here: #21803

For uptime, please follow the guidance of the semantic convention regarding this metric.

container.pid.thread_count & container.pid.thread_limit can be renamed to container.pid.threads.count and container.pid.threads.limit.

Please ping me once you have a PR up :)

[gbbr]

Thank you for looking James. I will start with a PR for container.uptime, and continue with the rest as per your instructions.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/dockerstats: @rmfitzpatrick @jamesmoessis

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mx-psi]

@gbbr can this be closed?

[gbbr]

Not yet, I'm going to work on adding some more of these.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/dockerstats: @rmfitzpatrick @jamesmoessis

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[gbbr]

Still being worked on in #21803

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/dockerstats: @rmfitzpatrick @jamesmoessis

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mx-psi]

#21803 has been merged so I am closing this :)