Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRay Receiver does not map links from Xray Segments #20350

Closed
Paulskit opened this issue Mar 27, 2023 · 5 comments
Closed

XRay Receiver does not map links from Xray Segments #20350

Paulskit opened this issue Mar 27, 2023 · 5 comments

Comments

@Paulskit
Copy link

Paulskit commented Mar 27, 2023

Component(s)

receiver/awsxray

What happened?

Description

X-Ray Receiver does not correctly propagate links.

Steps to Reproduce

Take any X-Ray segment that has links. Example (from BatchGetTraces):

{
  "id": "453dc95c740b9c59",
  "name": "lambda_function",
  "start_time": 1.67993501612e9,
  "trace_id": "1-6421c628-c569cf0ce2427008670d8d45",
  "end_time": 1.679935017219e9,
  "http": { "response": { "status": 200 } },
  "aws": { "request_id": "dcffe126-c03c-558e-aa5e-bdbd087220b5" },
  "origin": "AWS::Lambda",
  "resource_arn": "arn:aws:lambda:us-east-1:123456789012:function:lambda_function",
  "links": [
    {
      "trace_id": "1-6421c610-033542544abf615d316ee2de",
      "id": "2974158e19d0f339",
      "attributes": { "aws.xray.reserved.reference_type": "parent" }
    }
  ]
}

This is the output from logging exporter:

ResourceSpans #0
Resource SchemaURL: 
Resource attributes:
     -> service.name: Str(lambda_function)
     -> cloud.provider: Str(aws)
     -> aws.xray.resource_arn: Str(arn:aws:lambda:us-east-1:123456789012:function:lambda_function)
ScopeSpans #0
ScopeSpans SchemaURL: 
InstrumentationScope  
Span #0
    Trace ID       : 6421c628c569cf0ce2427008670d8d45
    Parent ID      : 
    ID             : 453dc95c740b9c59
    Name           : lambda_function
    Kind           : Server
    Start time     : 2023-03-27 16:36:56.12 +0000 UTC
    End time       : 2023-03-27 16:36:57.219000064 +0000 UTC
    Status code    : Unset
    Status message : 
Attributes:
     -> http.status_code: Int(200)
     -> aws.request_id: Str(dcffe126-c03c-558e-aa5e-bdbd087220b5)

Based on Logging Exporter Code, if provided, links printed to logs.

Expected Result

Links from Xray segments are mapped to OTLP Links

Actual Result

Links from Xray segments are not mapped

Collector version

v0.72.0

Environment information

Docker: amazon/aws-otel-collector:latest

OpenTelemetry Collector configuration

extensions:
  health_check:

receivers:
  awsxray:

exporters:
  logging:
    verbosity: 'detailed'

service:
  extensions:
    - health_check
  pipelines:
    traces:
      receivers:
        - awsxray
      exporters:
        - logging

Log output

No response

Additional context

No response

@Paulskit Paulskit added bug Something isn't working needs triage New item requiring triage labels Mar 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Mar 27, 2023
@Paulskit
Copy link
Author

Possibly will be fixed by #20353?

@willarmiros
Copy link
Contributor

Thanks for raising this @Paulskit - unfortunately #20353 will not resolve this as it only makes changes on the awsxrayexporter side, and this issue is for the receiver. We should keep this open as an enhancement request for the receiver.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 29, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants