Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Repository maintenance on opentelemetry-cpp #1727

Closed
marcalff opened this issue Oct 12, 2023 · 4 comments
Closed

REQUEST: Repository maintenance on opentelemetry-cpp #1727

marcalff opened this issue Oct 12, 2023 · 4 comments
Assignees
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@marcalff
Copy link
Member

marcalff commented Oct 12, 2023

Affected Repository

https://github.com/open-telemetry/opentelemetry-cpp

Requested changes

Per: https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md

"
If requested, foo-maintainers will be granted Admin permissions, and in return they must document any changes they make to the repository settings in a file named .github/repository-settings.md in their repository (other than temporarily disabling "Do not allow bypassing the above settings", see branch protection rules below).
"

Give 'Admin' permissions to @open-telemetry/cpp-maintainers

Purpose

We (cpp-maintainers) would like to have control on which CI build is required / not required, as part of the CI workflows.

This is needed as a lot of new builds have been added (but are not tagged as required),
and some existing builds may disappear (obsolete platform/configuration) or be changed in name/scope,
due to worflow cleanup.

I could not find anywhere in the github UI a way to set this up, so I assume the admin privilege is required for this.

Also, we need a way to temporarily bypass branch protections settings to forcefully merge a PR, when a failure is caused by issues external to opentelemetry-cpp (changes in github images for a given platform, network failures during the build).

Upon acceptance, file .github/repository-settings.md will be created and maintained to reflect local admin changes.

Expected Duration

Permanently

Repository Maintainers

cc @open-telemetry/cpp-maintainers

@marcalff marcalff added the area/repo-maintenance Maintenance of repos in the open-telemetry org label Oct 12, 2023
@arminru arminru self-assigned this Nov 2, 2023
@arminru
Copy link
Member

arminru commented Nov 2, 2023

Thank you for the detailed justification and updating the repository settings documentation.

After any changes, please double-check that the EasyCLA check is still marked as mandatory so no commits can slip in without a signed CLA.

@arminru
Copy link
Member

arminru commented Nov 2, 2023

I updated the access settings for @open-telemetry/cpp-maintainers to Admin and removed the explicit Mainain access for @marcalff since you're already covered via the maintainer's group anyway.

Also, @SergeyKanzhelev was still listed explicitly, I dropped your access setting as well.

@marcalff
Copy link
Member Author

marcalff commented Nov 3, 2023

Thanks @arminru

FYI, see pr:

I suggest to keep this issue opened until the PR is merged, to make sure we don't forget to create the repository settings documentation.

@arminru
Copy link
Member

arminru commented Nov 7, 2023

Thanks, @marcalff!

I'll close the issue now that your PR was merged.

@arminru arminru closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

2 participants