REQUEST: Approver role for pdelewski (opentelemetry-go-contrib, instrgen subdirectory in particular)

[pdelewski]

GitHub Username

pdelewski

Requirements

• I have reviewed the community membership guidelines (https://github.com/open-telemetry/community/blob/main/community-membership.md)
• I have enabled 2FA on my GitHub account. See https://github.com/settings/security
• I have subscribed to the Slack channel (use http://slack.cncf.io/ to get an invite)
• I am actively contributing to 1 or more OpenTelemetry subprojects
• I have two sponsors that meet the sponsor requirements listed in the community membership guidelines. Among other requirements, sponsors must be approvers or maintainers of at least one repository in the organization and not both affiliated with the same company
• I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

• @MadVikingGod
• @MrAlias

Each sponsor should reply to this issue with the comment "I support".
Please remember, it is an applicant's responsibility to get their sponsors' confirmation before submitting the request.

List of contributions to the OpenTelemetry project

• PRs reviewed / authored
• Donating autotel, a source-based instrumentation opentelemetry-go-instrumentation#6
• Donation proposal: OpenTelemetry source level automatic Go instrumentation opentelemetry-go-instrumentation#3
  Bunch of PHP commits
• Issues responded to
• SIG projects I am involved with
  PHP SIG
  GO AutoInstrumentation

[MadVikingGod]

I approve.

[SergeyKanzhelev]

Maintainers of individual sigs/repositories are promoting to approvers role.

In this case, the team go-approvers has the following maintainers:

It doesn't match the codeowners file: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CODEOWNERS#L17, I'm not sure why. But sponsors listed in this request definitely can approve.

Also I see that your alias is already in CODEOWNERS. So not sure if there is anything needed here. I'd let maintainers of go-contrib decide.

[pdelewski]

@SergeyKanzhelev Without being an approver I don't have merge permissions which was the goal

[SergeyKanzhelev]

I see. Maintainers for the repo can make you an approver. Thank you!

[trask]

@SergeyKanzhelev Without being an approver I don't have merge permissions which was the goal

@open-telemetry/go-maintainers if you have a need to grant approvers the right to merge can you open a community issue to discuss? currently see https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#branch-protection-rule-main

• Restrict who can push to matching branches: ✔️
  • Organization administrators, repository administrators, and users with the Maintain role

[pdelewski]

Seems that, it was my misunderstanding, I was thinking that approver have merge permissions