Support sampling_relevant attributes

[lmolkova]

Related to open-telemetry/opentelemetry-specification#1916

[Oberon00]

Please add a test to https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/src/tests/semconv/templating/test_markdown.py (plus accompanying input.md, expected.md and minimal yaml file with any name). Then this LGTM 👍

[lmolkova]

Please add a test to https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/src/tests/semconv/templating/test_markdown.py (plus accompanying input.md, expected.md and minimal yaml file with any name). Then this LGTM 👍

I don't know when I'll get a chance to work on this. Simple spec update turned out to be way too complicated.

[lmolkova]

Please add a test to https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/src/tests/semconv/templating/test_markdown.py (plus accompanying input.md, expected.md and minimal yaml file with any name). Then this LGTM 👍

Done!

[mariojonke]

changelog and version.py should probably be updated.

[Oberon00]

@mariojonke I can handle that in #67 or a follow-up.

[Oberon00]

Thank you!

[lmolkova]

I updated the changelog and version. If it still looks good, can someone please merge it? Thanks!

[arminru]

@open-telemetry/specs-approvers This will affect the semantic conventions we have in the spec, please take a look.

[lmolkova]

@open-telemetry/specs-approvers This will affect the semantic conventions we have in the spec, please take a look.

Current semantic conventions don't use sampling_relevant field, i.e. it does not change any of them.

Here's the change where I start using sampling_relevant open-telemetry/opentelemetry-specification#1916, which is approved and waiting for this PR to fix the build.

[lmolkova]

@Oberon00 @arminru @mariojonke can someone please merge it?

[Oberon00]

Only the TC can merge PRS in this repo, same as the spec (so @arminru can merge). IMHO we can merge this, because as you said the current spec does not use sampling_relevant.

[arminru]

Fair enough as the actual usage of it will still be reviewed in the spec.
Released as https://github.com/open-telemetry/build-tools/releases/tag/v0.7.0 so otel/semconvgen:0.7.0 is ready for you to reference in your spec PR @lmolkova.

[lmolkova]

thank you all!