Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto merge main into fsrs-browser failed #247

Closed
L-M-Sherlock opened this issue Oct 28, 2024 · 6 comments
Closed

Auto merge main into fsrs-browser failed #247

L-M-Sherlock opened this issue Oct 28, 2024 · 6 comments
Assignees

Comments

@L-M-Sherlock
Copy link
Member

After merging #246, the action failed. For details, see: https://github.com/open-spaced-repetition/fsrs-rs/actions/runs/11547276816/job/32136903375

@AlexErrant
Copy link
Member

I'm going to wait until the burn v0.15.0 upgrade is complete to batch all the work together since the merge action failed due to a burn update.

@L-M-Sherlock
Copy link
Member Author

I would wait for burn v0.16.0. The v0.15.0 slows down the training. I guess the next release won't happen soon. By the way, I'm curious whether burn has supported wasm with multi-threading. If so, we may not need to maintain a fork.

@L-M-Sherlock
Copy link
Member Author

closed by e35f1c5

@AlexErrant
Copy link
Member

I guess the next release won't happen soon.

Looks like they fixed it already - maybe they'll make a small patch release.

By the way, I'm curious whether burn has supported wasm with multi-threading. If so, we may not need to maintain a fork.

I believe they're unwilling to use Rust nightly, which is required for wasm with multi-threading:

This feature should be supported with Rust stable, since supporting another Rust toolchain is a lot of work and may slow down the development of other more important issues.

Until that changes, we must do this dance >_>

Sucks too because like, this feature is ~100 lines long... if you ignore CI. Which is a big if.

@L-M-Sherlock
Copy link
Member Author

Fine. I can wait. The patch only improves 6% performance of FSRS. When will Rust support it? 2025?

@AlexErrant
Copy link
Member

AlexErrant commented Oct 31, 2024

As far as I can tell, it's not being actively worked on: rust-lang/rust#77839

So no ETA >_>

This, by the way, is why I put so much effort into the CI - I expect this dance to go on for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants