Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide implementation of Value #417

Open
cdunn2001 opened this issue Feb 10, 2016 · 2 comments
Open

Hide implementation of Value #417

cdunn2001 opened this issue Feb 10, 2016 · 2 comments
Assignees
@cdunn2001
Labels
please discuss
Milestone
2.0.0

Comments

@cdunn2001
Copy link
Contributor

And I guess the iterators too. Then again, since this will be a major version bump, maybe we should drop the iterators, and later consider the ideas in #288.

This will help with #120 and #6. It will also let us use a "wiping allocator" as for #415 and #152.
@cdunn2001 cdunn2001 added this to the 2.0.0 milestone Feb 10, 2016
@cdunn2001 cdunn2001 self-assigned this Feb 10, 2016
@cdunn2001
Copy link
Contributor Author

I've started an impl branch in my own fork. I'm not sure when I'll time to finish this. Needs several hours of work.

@cdunn2001
Copy link
Contributor Author

New plan:

  • Create Json::Thing as the new API.
  • When we are ready,
    • Rename Thing->Value and Value->ValImpl.
    • Move the public classes.

This way, we can develop the new API in parallel with ongoing development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdunn2001 cdunn2001

Labels
please discuss
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@cdunn2001 @dota17