Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation failure #626

Open
dgargar-laude opened this issue Jan 21, 2025 · 7 comments · May be fixed by dgargar-laude/oqs-provider#1 or #633
Open

Automation failure #626

dgargar-laude opened this issue Jan 21, 2025 · 7 comments · May be fixed by dgargar-laude/oqs-provider#1 or #633
Labels
bug Something isn't working

Comments

@dgargar-laude
Copy link

Describe the bug
During my execution using docker I could find some details regarding some missing pip packages in scripts/fullbuild.sh

Expected behavior
I will expect a good script execution without script errors.

Environment (please complete the following information):
Docker img debian:bullseye-slim
OQSPROVIDER_TAG=0.8.0
OPENSSL_BRANCH=openssl-3.4.0
LIBOQS_BRANCH=0.12.0

I created a repository to show you the dockerfile working https://github.com/dgargar-laude/oqsproviderDockerfile

@dgargar-laude dgargar-laude added the bug Something isn't working label Jan 21, 2025
@SWilson4
Copy link
Member

Hi @dgargar-laude, thanks for the report. I think your patch makes sense—would you like to submit it as a PR for review?

@dgargar-laude
Copy link
Author

Hi, as far as I know I need to create a new branch first, based on tag 0.8.0
Could I create it?

@baentsch
Copy link
Member

No -- and you don't need to do that. Simply raise a PR to "main".

@SWilson4
Copy link
Member

Expanding on the above, you'll need to fork the repo and create a PR from your fork.

@dgargar-laude dgargar-laude linked a pull request Jan 24, 2025 that will close this issue
@dgargar-laude
Copy link
Author

Here is the PR dgargar-laude#1

@SWilson4
Copy link
Member

Here is the PR dgargar-laude#1

You'll need to change the target branch from the main branch of your fork to the main branch of the open-quantum-safe repo.

@dgargar-laude dgargar-laude linked a pull request Jan 30, 2025 that will close this issue
@dgargar-laude
Copy link
Author

Here is the pull req

#633

@SWilson4 SWilson4 linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants