From 3ff72385ed032c297c99a58bcf8b1283507a2278 Mon Sep 17 00:00:00 2001 From: martijnvdp Date: Fri, 30 Aug 2024 09:55:24 +0200 Subject: [PATCH] fix: vap error logging for rego only templates Signed-off-by: martijnvdp --- .../constrainttemplate/constrainttemplate_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/constrainttemplate/constrainttemplate_controller.go b/pkg/controller/constrainttemplate/constrainttemplate_controller.go index cfc728eacac..a9dbb7cccea 100644 --- a/pkg/controller/constrainttemplate/constrainttemplate_controller.go +++ b/pkg/controller/constrainttemplate/constrainttemplate_controller.go @@ -379,7 +379,7 @@ func (r *ReconcileConstraintTemplate) Reconcile(ctx context.Context, request rec return reconcile.Result{}, err } generateVap, err := constraint.ShouldGenerateVAP(unversionedCT) - if err != nil || !errors.Is(err, celSchema.ErrCodeNotDefined) { + if err != nil && !errors.Is(err, celSchema.ErrCodeNotDefined) { logger.Error(err, "generateVap error") } logger.Info("generateVap", "r.generateVap", generateVap)