From 7676945c6ecff1375d70ef23bb104f8118eb8570 Mon Sep 17 00:00:00 2001 From: Max Smythe Date: Mon, 9 Jan 2023 17:58:47 -0800 Subject: [PATCH 1/2] feat: More verbose logging for audit Signed-off-by: Max Smythe --- pkg/audit/manager.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/audit/manager.go b/pkg/audit/manager.go index 561af6c531c..264503c5898 100644 --- a/pkg/audit/manager.go +++ b/pkg/audit/manager.go @@ -368,6 +368,7 @@ func (am *Manager) auditResources( for gv, gvKinds := range clusterAPIResources { kindsLoop: for kind := range gvKinds { + log.Info("Listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) // delete all existing folders from cache dir before starting next kind err := am.removeAllFromDir(*apiCacheDir, int(*auditChunkSize)) if err != nil { @@ -436,15 +437,19 @@ func (am *Manager) auditResources( resourceVersion = objList.GetResourceVersion() opts.Continue = objList.GetContinue() if opts.Continue == "" { + log.Info("Finished listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) break } + log.Info("Requesting next chunk of objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) } // Loop through all subDirs to review all files for this kind. + log.Info("Reviewing objects for GVK", gv.Group, "version", gv.Version, "kind", kind) err = am.reviewObjects(ctx, kind, folderCount, namespaceCache, updateLists, totalViolationsPerConstraint, totalViolationsPerEnforcementAction, timestamp) if err != nil { errs = append(errs, err) continue } + log.Info("Review complete for GVK", gv.Group, "version", gv.Version, "kind", kind) } } From 80cbd436da5492d34ef6371c07d5c89fc9de5328 Mon Sep 17 00:00:00 2001 From: Max Smythe Date: Tue, 10 Jan 2023 19:17:55 -0800 Subject: [PATCH 2/2] Reduce log priority Signed-off-by: Max Smythe --- pkg/audit/manager.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/audit/manager.go b/pkg/audit/manager.go index 264503c5898..0b3d8d9dbfa 100644 --- a/pkg/audit/manager.go +++ b/pkg/audit/manager.go @@ -368,7 +368,7 @@ func (am *Manager) auditResources( for gv, gvKinds := range clusterAPIResources { kindsLoop: for kind := range gvKinds { - log.Info("Listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) + am.log.V(logging.DebugLevel).Info("Listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) // delete all existing folders from cache dir before starting next kind err := am.removeAllFromDir(*apiCacheDir, int(*auditChunkSize)) if err != nil { @@ -437,19 +437,19 @@ func (am *Manager) auditResources( resourceVersion = objList.GetResourceVersion() opts.Continue = objList.GetContinue() if opts.Continue == "" { - log.Info("Finished listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) + am.log.V(logging.DebugLevel).Info("Finished listing objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) break } - log.Info("Requesting next chunk of objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) + am.log.V(logging.DebugLevel).Info("Requesting next chunk of objects for GVK", "group", gv.Group, "version", gv.Version, "kind", kind) } // Loop through all subDirs to review all files for this kind. - log.Info("Reviewing objects for GVK", gv.Group, "version", gv.Version, "kind", kind) + am.log.V(logging.DebugLevel).Info("Reviewing objects for GVK", gv.Group, "version", gv.Version, "kind", kind) err = am.reviewObjects(ctx, kind, folderCount, namespaceCache, updateLists, totalViolationsPerConstraint, totalViolationsPerEnforcementAction, timestamp) if err != nil { errs = append(errs, err) continue } - log.Info("Review complete for GVK", gv.Group, "version", gv.Version, "kind", kind) + am.log.V(logging.DebugLevel).Info("Review complete for GVK", gv.Group, "version", gv.Version, "kind", kind) } }