From 5d771aa7bfce8d6168e364c60f224bd1abbd4e95 Mon Sep 17 00:00:00 2001 From: David Wootton Date: Mon, 12 Dec 2022 16:47:29 -0500 Subject: [PATCH] Fix missing lock release in ompi_coll_adapt_ibcast_generic Coverity CID 1498641 Signed-off-by: David Wootton --- ompi/mca/coll/adapt/coll_adapt_ibcast.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ompi/mca/coll/adapt/coll_adapt_ibcast.c b/ompi/mca/coll/adapt/coll_adapt_ibcast.c index dd99de44660..3c6c2bac483 100644 --- a/ompi/mca/coll/adapt/coll_adapt_ibcast.c +++ b/ompi/mca/coll/adapt/coll_adapt_ibcast.c @@ -558,11 +558,11 @@ int ompi_coll_adapt_ibcast_generic(void *buff, int count, struct ompi_datatype_t MCA_PML_CALL(irecv (recv_buff, recv_count, datatype, context->peer, con->ibcast_tag - i, comm, &recv_req)); + /* Set receive callback */ + OPAL_THREAD_UNLOCK(mutex); if (MPI_SUCCESS != err) { return err; } - /* Set receive callback */ - OPAL_THREAD_UNLOCK(mutex); ompi_request_set_callback(recv_req, recv_cb, context); OPAL_THREAD_LOCK(mutex); }