runtime: warn before using singleton mode #10289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PMIx is unreachable, but a PMI1/2 or SLURM environment is detected, issue a warning before "falling back" to singleton mode. Refs. open-mpi#10286 Signed-off-by: Gilles Gouaillardet <[email protected]>
Contributor
Author
|
@bwbarrett here is an idea on how to tackle #10286 We could also add a MCA parameter to select which action should be taken:
FWIW, I tested both SLURM and PMI in order to support
|
awlauria
reviewed
Apr 19, 2022
| rank_str = getenv("SLURM_PROCID"); | ||
| } | ||
| int rank = (NULL != rank_str)?atoi(rank_str):0; | ||
| if (0 == rank) { |
Contributor
There was a problem hiding this comment.
What if this really is rank 0? Should -1 be used instead?
Contributor
Author
There was a problem hiding this comment.
The rationale for being 0 is we do our best to limit the warning message to rank 0. But if we cannot figure out the rank (likely caused by a busted environment?) I'd rather have all the ranks print the warning message than none.
bwbarrett
approved these changes
Apr 20, 2022
| if (NULL == size_str) { | ||
| size_str = getenv("SLURM_NPROCS"); | ||
| } | ||
| int size = (NULL != size_str)?atoi(size_str):1; |
Member
There was a problem hiding this comment.
you made my brain hurt for no reason :).
| rank_str = getenv("SLURM_PROCID"); | ||
| } | ||
| int rank = (NULL != rank_str)?atoi(rank_str):0; | ||
| if (0 == rank) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PMIx is unreachable, but a PMI1/2 or SLURM environment is detected,
issue a warning before "falling back" to singleton mode.
Refs. #10286
Signed-off-by: Gilles Gouaillardet [email protected]