Skip to content

Commit dfec531

Browse files
committed
Merge pull request #1502 from jsquyres/pr/fix-libfabric-user-intent
fix libfabric user intent
2 parents ddc99d2 + bd3c15c commit dfec531

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

config/opal_check_libfabric.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ AC_DEFUN([OPAL_CHECK_LIBFABRIC],[
8888

8989
AS_IF([test $opal_check_libfabric_happy = yes],
9090
[$2],
91-
[AS_IF([test "$opal_want_libfabric" = "yes"],
91+
[AS_IF([test -n "$with_libfabric" && test "$with_libfabric" != "no"],
9292
[AC_MSG_WARN([libfabric support requested (via --with-libfabric), but not found.])
9393
AC_MSG_ERROR([Cannot continue.])])
9494
$3])

config/opal_summary.m4

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ AC_DEFUN([OMPI_SUMMARY_ADD],[
1919
ompi_summary_section_current=$(eval echo \$ompi_summary_values_$ompi_summary_section)
2020

2121
if test -z "$ompi_summary_section_current" ; then
22-
if test -z "$ompi_summary_sections" ; then
23-
ompi_summary_sections=$ompi_summary_section
24-
else
25-
ompi_summary_sections="$ompi_summary_sections $ompi_summary_section"
26-
fi
27-
eval ompi_summary_values_$ompi_summary_section=\"$ompi_summary_line\"
22+
if test -z "$ompi_summary_sections" ; then
23+
ompi_summary_sections=$ompi_summary_section
24+
else
25+
ompi_summary_sections="$ompi_summary_sections $ompi_summary_section"
26+
fi
27+
eval ompi_summary_values_$ompi_summary_section=\"$ompi_summary_line\"
2828
else
29-
eval ompi_summary_values_$ompi_summary_section=\"$ompi_summary_section_current,$ompi_summary_line\"
29+
eval ompi_summary_values_$ompi_summary_section=\"$ompi_summary_section_current,$ompi_summary_line\"
3030
fi
3131

3232
OPAL_VAR_SCOPE_POP
@@ -42,23 +42,23 @@ Version: $OMPI_MAJOR_VERSION.$OMPI_MINOR_VERSION.$OMPI_RELEASE_VERSION$OMPI_GREE
4242
EOF
4343

4444
if test "$project_ompi_amc" = "true" ; then
45-
echo "Build MPI C bindings: yes"
45+
echo "Build MPI C bindings: yes"
4646
else
47-
echo "Build MPI C bindings: no"
47+
echo "Build MPI C bindings: no"
4848
fi
4949

5050
dnl Print out the bindings if we are building OMPI
5151
if test "$project_ompi_amc" = "true" ; then
5252
if test x$enable_mpi_cxx = xyes ; then
53-
echo "Build MPI C++ bindings (deprecated): yes"
53+
echo "Build MPI C++ bindings (deprecated): yes"
5454
else
55-
echo "Build MPI C++ bindings (deprecated): no"
55+
echo "Build MPI C++ bindings (deprecated): no"
5656
fi
5757

5858
if test $OMPI_BUILD_FORTRAN_BINDINGS = $OMPI_FORTRAN_MPIFH_BINDINGS ; then
59-
echo "Build MPI Fortran bindings: mpif.h"
59+
echo "Build MPI Fortran bindings: mpif.h"
6060
elif test $OMPI_BUILD_FORTRAN_BINDINGS = $OMPI_FORTRAN_USEMPI_BINDINGS ; then
61-
echo "Build MPI Fortran bindings: mpif.h, use mpi"
61+
echo "Build MPI Fortran bindings: mpif.h, use mpi"
6262
elif test $OMPI_BUILD_FORTRAN_BINDINGS = $OMPI_FORTRAN_USEMPIF08_BINDINGS ; then
6363
echo "Build MPI Fortran bindings: mpif.h, use mpi, use mpi_f08"
6464
else
@@ -73,41 +73,41 @@ EOF
7373
fi
7474

7575
if test "$project_oshmem_amc" = "true" ; then
76-
echo "Build Open SHMEM support: yes"
76+
echo "Build Open SHMEM support: yes"
7777
else
78-
echo "Build Open SHMEM support: no"
78+
echo "Build Open SHMEM support: no"
7979
fi
8080

8181
if test $WANT_DEBUG = 0 ; then
82-
echo "Debug build: no"
82+
echo "Debug build: no"
8383
else
84-
echo "Debug build: yes"
84+
echo "Debug build: yes"
8585
fi
8686

8787
if test ! -z $with_platform ; then
88-
echo "Platform file: $with_platform"
88+
echo "Platform file: $with_platform"
8989
else
90-
echo "Platform file: (none)"
90+
echo "Platform file: (none)"
9191
fi
9292

9393
echo
9494

9595
for ompi_summary_section in $(echo $ompi_summary_sections) ; do
96-
ompi_summary_section_name=$(echo $ompi_summary_section | tr '_' ' ')
97-
echo "$ompi_summary_section_name"
98-
echo "-----------------------"
99-
echo "$(eval echo \$ompi_summary_values_$ompi_summary_section)" | tr ',' $'\n' | sort -f
100-
echo
96+
ompi_summary_section_name=$(echo $ompi_summary_section | tr '_' ' ')
97+
echo "$ompi_summary_section_name"
98+
echo "-----------------------"
99+
echo "$(eval echo \$ompi_summary_values_$ompi_summary_section)" | tr ',' $'\n' | sort -f
100+
echo " "
101101
done
102102

103103
if test $WANT_DEBUG = 1 ; then
104104
cat <<EOF
105105
*****************************************************************************
106106
THIS IS A DEBUG BUILD! DO NOT USE THIS BUILD FOR PERFORMANCE MEASUREMENTS!
107107
*****************************************************************************
108+
108109
EOF
109110
fi
110-
echo " "
111111

112112
OPAL_VAR_SCOPE_POP
113113
])

0 commit comments

Comments
 (0)