Checkpoint gds/shmem work. (#2579)

Signed-off-by: Samuel K. Gutierrez <[email protected]>

Author: samuelkgutierrez

src/mca/gds/shmem/gds_shmem.c

@@ -19,9 +19,6 @@
 #include "gds_shmem_store.h"
 #include "gds_shmem_fetch.h"
 
-#include "src/mca/gds/base/base.h"
-#include "src/mca/pcompress/base/base.h"
-
 #include "src/class/pmix_list.h"
 #include "src/client/pmix_client_ops.h"
 #include "src/server/pmix_server_ops.h"
@@ -32,6 +29,8 @@
 #include "src/util/pmix_environ.h"
 #include "src/util/pmix_shmem.h"
 
+#include "src/mca/pcompress/base/base.h"
+
 #ifdef HAVE_STRING_H
 #include <string.h>
 #endif
@@ -825,6 +824,8 @@ job_construct(
     //
     j->nspace = NULL;
     //
+    PMIX_CONSTRUCT(&j->jobinfo, pmix_list_t);
+    //
     PMIX_CONSTRUCT(&j->nodeinfo, pmix_list_t);
     //
     j->session = NULL;
@@ -853,6 +854,8 @@ job_destruct(
     //
     PMIX_RELEASE(j->nspace);
     //
+    PMIX_LIST_DESTRUCT(&j->jobinfo);
+    //
     PMIX_LIST_DESTRUCT(&j->nodeinfo);
     //
     PMIX_RELEASE(j->session);
@@ -900,9 +903,11 @@ static void
 app_destruct(
     pmix_gds_shmem_app_t *a
 ) {
+    a->appnum = 0;
     PMIX_LIST_DESTRUCT(&a->appinfo);
     PMIX_LIST_DESTRUCT(&a->nodeinfo);
     PMIX_RELEASE(a->job);
+    a->job = NULL;
 }
 
 PMIX_CLASS_INSTANCE(
@@ -1232,6 +1237,7 @@ store(
     else if (PMIX_CHECK_KEY(kval, PMIX_JOB_INFO_ARRAY)) {
         return PMIX_ERR_NOT_SUPPORTED;
     }
+    // Else we aren't dealing with an array type.
     // See if the proc is me. We cannot use CHECK_PROCID
     // as we don't want rank=wildcard to match.
     if (proc->rank == pmix_globals.myid.rank &&

src/mca/gds/shmem/gds_shmem.h

@@ -26,6 +26,10 @@
 
 #include "include/pmix_common.h"
 
+#ifdef HAVE_UNISTD_H
+#include <unistd.h>
+#endif
+
 /**
  * The name of this module.
  */
@@ -110,9 +114,11 @@ typedef struct {
     char *nspace_id;
     /** Pointer to the namespace. */
     pmix_namespace_t *nspace;
-    // TODO(skg) Is the session nodeinfo the same info?
+    /** Job information. */
+    pmix_list_t jobinfo;
     /** Node information. */
     pmix_list_t nodeinfo;
+    // TODO(skg) Is the session nodeinfo the same info?
     /** Session information. */
     pmix_gds_shmem_session_t *session;
     /** List of applications in this job. */

src/mca/gds/shmem/gds_shmem_component.c

@@ -30,10 +30,6 @@
 
 #include "gds_shmem.h"
 
-#ifdef HAVE_UNISTD_H
-#include <unistd.h>
-#endif
-
 static int
 component_open(void)
 {