From 396b7397fba061326fe73be91b02ad980eec00d9 Mon Sep 17 00:00:00 2001 From: Federico Bond Date: Tue, 26 Mar 2024 13:36:05 +1100 Subject: [PATCH] fix: fix types for hints in OTel TracingHook Signed-off-by: Federico Bond --- hooks/openfeature-hooks-opentelemetry/pyproject.toml | 2 +- .../openfeature/contrib/hook/opentelemetry/__init__.py | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hooks/openfeature-hooks-opentelemetry/pyproject.toml b/hooks/openfeature-hooks-opentelemetry/pyproject.toml index 571dd6d2..0f13dc24 100644 --- a/hooks/openfeature-hooks-opentelemetry/pyproject.toml +++ b/hooks/openfeature-hooks-opentelemetry/pyproject.toml @@ -17,7 +17,7 @@ classifiers = [ ] keywords = [] dependencies = [ - "openfeature-sdk>=0.4.0", + "openfeature-sdk>=0.6.0", "opentelemetry-api", ] requires-python = ">=3.8" diff --git a/hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py b/hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py index 7a813bdb..6102be16 100644 --- a/hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py +++ b/hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py @@ -1,7 +1,7 @@ import json from openfeature.flag_evaluation import FlagEvaluationDetails -from openfeature.hook import Hook, HookContext +from openfeature.hook import Hook, HookContext, HookHints from opentelemetry import trace OTEL_EVENT_NAME = "feature_flag" @@ -15,7 +15,10 @@ class EventAttributes: class TracingHook(Hook): def after( - self, hook_context: HookContext, details: FlagEvaluationDetails, hints: dict + self, + hook_context: HookContext, + details: FlagEvaluationDetails, + hints: HookHints, ) -> None: current_span = trace.get_current_span() @@ -39,7 +42,7 @@ def after( current_span.add_event(OTEL_EVENT_NAME, event_attributes) def error( - self, hook_context: HookContext, exception: Exception, hints: dict + self, hook_context: HookContext, exception: Exception, hints: HookHints ) -> None: current_span = trace.get_current_span() current_span.record_exception(exception)