feat: add support for flagd flag metadata #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 94.00% 93.99% -0.01%
==========================================
Files 18 18
Lines 950 983 +33
==========================================
+ Hits 893 924 +31
- Misses 57 59 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
gruebel
approved these changes
Mar 24, 2025
Member
gruebel
left a comment
gruebel
left a comment
There was a problem hiding this comment.
nice work 🍻 just string formatting needs a some adjustments. don't forget to run ruff locally, will probably result in slight different line breaks.
...openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py
Outdated
Show resolved
Hide resolved
...openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py
Outdated
Show resolved
Hide resolved
...openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py
Show resolved
Hide resolved
1 task
…rovider/flagd/resolvers/process/flags.py Co-authored-by: Anton Grübel <[email protected]> Signed-off-by: chrfwow <[email protected]>
…rovider/flagd/resolvers/process/flags.py Co-authored-by: Anton Grübel <[email protected]> Signed-off-by: chrfwow <[email protected]>
…rovider/flagd/resolvers/process/flags.py Co-authored-by: Anton Grübel <[email protected]> Signed-off-by: chrfwow <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for flag and flag set metadata in flagd
Related Issues
Fixes #119
Waiting for open-feature/flagd-testbed#242
Follow-up Tasks
I will open a PR for additional e2e tests in the flagd testbed