Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TrackingEventDetails interface to include numeric getValue() call #1328

Conversation

jonathannorris
Copy link
Member

This PR

  • fix: TrackingEventDetails interface to include numeric Optional<Number> getValue(); function interface. Only the Value getValue(String key); was being exposed by extending Structure.

@jonathannorris jonathannorris requested a review from a team as a code owner February 13, 2025 15:54
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this change should make the live for a lot of people a lot easier and this interface method is definitely rounding up the experience. Thank you!!

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (3baf0df) to head (73351ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1328      +/-   ##
============================================
+ Coverage     93.51%   93.69%   +0.18%     
- Complexity      463      464       +1     
============================================
  Files            43       43              
  Lines          1110     1110              
  Branches         89       89              
============================================
+ Hits           1038     1040       +2     
+ Misses           44       43       -1     
+ Partials         28       27       -1     
Flag Coverage Δ
unittests 93.69% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toddbaert
Copy link
Member

Oh yes this is a nice improvement, thanks.

We are still working on getting tracking implemented internally at our org, but I'm sure we would have run into this soon.

@toddbaert toddbaert merged commit 08c38fb into open-feature:main Feb 13, 2025
11 checks passed
@jonathannorris jonathannorris deleted the fix-tracking-event-details-interface branch February 13, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants