chore: various non-functional refactors #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Aug 23, 2024
| * An extension point which can run around flag resolution. They are intended to be used as a way to add custom logic | ||
| * to the lifecycle of flag evaluation. | ||
| * | ||
| * @see Hook | ||
| */ | ||
| public interface BooleanHook extends Hook<Boolean> { |
There was a problem hiding this comment.
inheritDoc isn't valid for classes.
toddbaert
commented
Aug 23, 2024
| @@ -16,8 +17,8 @@ | |||
| @SuppressWarnings("PMD.BeanMembersShouldSerialize") | |||
| public final class ImmutableContext implements EvaluationContext { | |||
|
|
|||
| @Delegate | |||
| private final Structure structure; | |||
| @Delegate(excludes = DelegateExclusions.class) | |||
There was a problem hiding this comment.
merge was coming both from this delegation and the superclass, which causes some odd compiler warnings. It's just coming via inheritance now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
============================================
+ Coverage 95.03% 95.25% +0.22%
- Complexity 392 393 +1
============================================
Files 38 38
Lines 886 886
Branches 54 54
============================================
+ Hits 842 844 +2
+ Misses 24 23 -1
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toddbaert
force-pushed
the
chore/non-functional-fixes
branch
5 times, most recently
from
e971afa to
63fda52
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/non-functional-fixes
branch
from
63fda52 to
9e7574d
Compare
|
toddbaert
commented
Aug 23, 2024
Comment on lines
+8
to
+10
| /** | ||
| * JaCoCo ignores coverage of methods annotated with any annotation with "generated" in the name. | ||
| */ |
aepfli
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small fixes to address warnings. None are functional.