fix: Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito issue

[ryanprayogo]

Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito issue

Workaround to make Mockito tests to pass under Java 21 due to this open Mockito bug

Related Issues

Fixes #1059

Notes

Follow-up Tasks

How to test

[justinabrahms]

The fix looks reasonable given the issue output.

The linked issue suggests that a more recent version of mockito may alleviate the need to set these vars. The PR merged in 2023. They had a release this past May. Could we just upgrade mockito and have that work instead?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (b7ed041) to head (d4485cc).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1060      +/-   ##
============================================
+ Coverage     95.03%   95.25%   +0.22%     
- Complexity      392      393       +1     
============================================
  Files            38       38              
  Lines           886      886              
  Branches         54       54              
============================================
+ Hits            842      844       +2     
+ Misses           24       23       -1     
+ Partials         20       19       -1     

Flag	Coverage Δ
unittests	95.25% <ø> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ryanprayogo]

Fixing maven warnings

[WARNING] The expression ${groupId} is deprecated. Please use ${project.groupId} instead.
[WARNING] The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead.

[toddbaert]

This solves the issue for me locally! very nice to have!

[toddbaert]

The fix looks reasonable given the issue output.

The linked issue suggests that a more recent version of mockito may alleviate the need to set these vars. The PR merged in 2023. They had a release this past May. Could we just upgrade mockito and have that work instead?

We could try mockito 5. This is the latest version of 4.

[toddbaert]

The fix looks reasonable given the issue output.
The linked issue suggests that a more recent version of mockito may alleviate the need to set these vars. The PR merged in 2023. They had a release this past May. Could we just upgrade mockito and have that work instead?

We could try mockito 5. This is the latest version of 4.

@justinabrahms ahh, we can't. Mockito 5 doesn't support Java 8. For as long as we want to have Java 8 support, we need to stick with Mockito 4. This PR seems like the best of both worlds.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud