Skip to content

fix: Ensure AddPolicyName without adding a Provider does not get stuck in infinite loop #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askpt merged 2 commits into from
Oct 29, 2025
Merged

fix: Ensure AddPolicyName without adding a Provider does not get stuck in infinite loop #606

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb24fd
Fix issue when adding a DefaultNamePolicy
kylejuliandev Oct 21, 2025
774be8e
Address copilot comments and improve unit test coverage
kylejuliandev Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/OpenFeature.Hosting/OpenFeatureBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,16 +223,42 @@ internal static OpenFeatureBuilder AddPolicyBasedClient(this OpenFeatureBuilder
{
var policy = provider.GetRequiredService<IOptions<PolicyNameOptions>>().Value;
var name = policy.DefaultNameSelector(provider);

if (name == null)
{
return provider.GetRequiredService<IFeatureClient>();
return ResolveFeatureClient(provider);
}
return provider.GetRequiredKeyedService<IFeatureClient>(name);

return ResolveFeatureClient(provider, name);
});

return builder;
}

private static IFeatureClient ResolveFeatureClient(IServiceProvider provider, string? name = null)
{
var api = provider.GetRequiredService<Api>();
var context = provider.GetService<EvaluationContext>();
FeatureClient client;
if (name == null)
{
client = api.GetClient();
if (context is not null)
{
client.SetContext(context);
}
return client;
}

client = api.GetClient(name);
if (context is not null)
{
client.SetContext(context);
}

return client;
}

/// <summary>
/// Configures policy name options for OpenFeature using the specified options type.
/// </summary>
Expand Down