Skip to content

Conversation

@askpt
Copy link
Member

@askpt askpt commented Mar 28, 2025

This pull request includes updates to the CONTRIBUTING.md file to improve clarity and update outdated information. The most important changes include updating the .NET SDK requirements, modifying instructions for running E2E tests, and adding new guidelines for pull request conventions.

Updates to .NET SDK requirements and tools:

  • Updated the .NET SDK requirements to .Net 8 or higher and ensured consistency in formatting for tool names.

Modifications to E2E test instructions:

  • Simplified the instructions for running E2E tests by removing the need to manually copy test files.

Guidelines for pull request conventions:

  • Added new guidelines for pull request conventions, including the use of conventional commit messages and specifying types of changes such as build, ci, docs, feat, fix, perf, refactor, style, and test.

Formatting improvements:

  • Added missing blank lines for better readability in command instructions. [1] [2] [3]

@askpt askpt requested a review from a team as a code owner March 28, 2025 16:31
@askpt askpt requested a review from Copilot March 28, 2025 16:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CONTRIBUTING.md file to improve clarity in contributing guidelines and update procedures for .NET SDK requirements, E2E test instructions, and automated changelog generation.

  • Updated the .NET SDK requirement to .NET 8 or higher.
  • Clarified E2E test instructions by removing the manual file copy step.
  • Switched the automated changelog generation tool and reformatted lists and code blocks for consistency.

askpt and others added 2 commits March 28, 2025 16:35
Co-authored-by: Copilot <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt requested a review from Copilot March 28, 2025 16:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the contributing guidelines to improve documentation clarity and update procedures. Key changes include updating the .NET SDK requirements to .NET 8 or higher, clarifying the E2E test instructions by removing manual file copy, and switching the automated changelog generation tool to googleapis/release-please-action.

askpt and others added 2 commits March 28, 2025 16:41
@askpt askpt requested a review from Copilot March 28, 2025 16:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CONTRIBUTING.md file to improve clarity and update procedures based on the latest tooling and requirements.

  • Updated .NET SDK requirement from .NET Core 3 to .NET 8 or higher.
  • Clarified E2E test instructions to remove manual file copying.
  • Updated automated changelog generation tool and related conventions.
Comments suppressed due to low confidence (1)

CONTRIBUTING.md:72

  • [nitpick] Consider rephrasing this sentence for improved clarity. For example, merge the two fragments into a single sentence.
Since all the spec files are copied during the build process. Now you can run the tests using:

@askpt askpt enabled auto-merge March 28, 2025 17:55
@askpt askpt requested review from a team March 28, 2025 17:58
@beeme1mr beeme1mr disabled auto-merge April 1, 2025 10:13
@beeme1mr beeme1mr merged commit 84ea288 into main Apr 1, 2025
9 checks passed
@beeme1mr beeme1mr deleted the askpt/change-contributing branch April 1, 2025 10:14
github-merge-queue bot pushed a commit that referenced this pull request Apr 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.4.0](v2.3.2...v2.4.0)
(2025-04-14)


### 🐛 Bug Fixes

* Refactor error handling and improve documentation
([#417](#417))
([b0b168f](b0b168f))


### ✨ New Features

* update FeatureLifecycleStateOptions.StopState default to Stopped
([#414](#414))
([6c23f21](6c23f21))


### 🧹 Chore

* **deps:** update github/codeql-action digest to 45775bd
([#419](#419))
([2bed467](2bed467))
* restrict publish to environment
([#431](#431))
([0c222cb](0c222cb))


### 📚 Documentation

* Update contributing guidelines
([#413](#413))
([84ea288](84ea288))


### 🔄 Refactoring

* simplify the InternalsVisibleTo usage
([#408](#408))
([4043d3d](4043d3d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
WeihanLi pushed a commit to WeihanLi/openfeature-dotnet-sdk that referenced this pull request May 14, 2025
🤖 I have created a release *beep* *boop*
---

##
[2.4.0](open-feature/dotnet-sdk@v2.3.2...v2.4.0)
(2025-04-14)

### 🐛 Bug Fixes

* Refactor error handling and improve documentation
([open-feature#417](open-feature#417))
([b0b168f](open-feature@b0b168f))

### ✨ New Features

* update FeatureLifecycleStateOptions.StopState default to Stopped
([open-feature#414](open-feature#414))
([6c23f21](open-feature@6c23f21))

### 🧹 Chore

* **deps:** update github/codeql-action digest to 45775bd
([open-feature#419](open-feature#419))
([2bed467](open-feature@2bed467))
* restrict publish to environment
([open-feature#431](open-feature#431))
([0c222cb](open-feature@0c222cb))

### 📚 Documentation

* Update contributing guidelines
([open-feature#413](open-feature#413))
([84ea288](open-feature@84ea288))

### 🔄 Refactoring

* simplify the InternalsVisibleTo usage
([open-feature#408](open-feature#408))
([4043d3d](open-feature@4043d3d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants