Skip to content

Verawood release branch #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xitij2000 wants to merge 8 commits into
base: opencraft/verawood
Choose a base branch
from
Open

Verawood release branch #859

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
610da02
feat: allow switching anonymous user ID hashing algorithm from shake …
kaustavb12 Aug 8, 2022
9fab2fd
temp: Add configuration option to redirect to external site when TAP …
xitij2000 May 24, 2023
036cd1a
feat: all eSHE role features squashed in one commit
0x29a Jun 26, 2023
23b2c92
fix: fix tests for eSHE role
xitij2000 Aug 12, 2026
31d4d84
feat: add a feature flag to disable dates tab for all courses
Cup0fCoffee Apr 15, 2024
d6fb45e
fix: prevent redirects to /undefined after saml auth
tecoholic Aug 13, 2024
17b42d8
feat: allow Bearer auth for sequence metadata
0x29a Oct 23, 2024
243e782
fix: prevent null start date in course details (#792)
viadanna Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: prevent redirects to /undefined after saml auth 
When a user authenticates using SAML, but their accounts aren't linked,
they land on the login page with the message to link their accounts. If the
`OC_REDIRECT_ON_TPA_UNLINKED_ACCOUNT` value is not set, they are redirected to
`/undefined`. This commit checks that the `redirectURL` is a valid non-empty
string before performing the redirect.

The bug was introduced in 91f8d36, so this can be safely dropped once that
temporary commit is removed from our branches. For Redwood, the relevant
commit hash is 64f5dea.

Internal-ref: https://tasks.opencraft.com/browse/BB-9010
(cherry picked from commit 9ade4ea)
(cherry picked from commit b801f99)
(cherry picked from commit 21787b7)
(cherry picked from commit ed2d2b5)
(cherry picked from commit f9053ef)
  • Loading branch information
@tecoholic @xitij2000
tecoholic authored and xitij2000 committed Aug 12, 2026
commit d6fb45ebe5625ae73b202cca0beb37b9682210b2
4 changes: 3 additions & 1 deletion lms/static/js/student_account/views/LoginView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@
this.clearFormErrors();
this.renderThirdPartyAuthWarning();
}
window.location.href = redirectURL;
if (typeof redirectURL === "string" && redirectURL.length) {
window.location.href = redirectURL;
}
} else {
this.renderErrors(this.defaultFormErrorsTitle, this.errors);
}
Expand Down