From 84cb231c518ac6c6d0c9a56b85bbeefef6d0d31c Mon Sep 17 00:00:00 2001 From: Arjun Singh Yadav Date: Tue, 6 Apr 2021 04:11:08 +0530 Subject: [PATCH] [BB-3966] Fix UX issues (#761) * BB-3966 Header: Expand to screen width. * BB-3966 Update Redeployment toolbar. * BB-3966: Align console content to header * BB-3966 Fix footer at bottom --- .../ConsoleContainer/ConsoleContainer.tsx | 2 +- .../ConsoleContainer.spec.tsx.snap | 2 +- .../__snapshots__/ConsolePage.spec.tsx.snap | 8 +- .../components/ConsolePage/styles.scss | 3 +- .../__snapshots__/CoursesManage.spec.tsx.snap | 52 ++---- .../Hero/__snapshots__/Hero.spec.tsx.snap | 4 +- .../InstanceSettings.spec.tsx.snap | 4 +- .../Logos/__snapshots__/Logos.spec.tsx.snap | 4 +- .../__snapshots__/NoticeBoard.spec.tsx.snap | 4 +- .../RedeploymentToolbar.tsx | 11 +- .../RedeploymentToolbar.spec.tsx.snap | 24 +-- .../RedeploymentToolbar/styles.scss | 14 +- .../__snapshots__/ThemeButtons.spec.tsx.snap | 4 +- .../ThemeNavigation.spec.tsx.snap | 4 +- .../ThemePreviewAndColors.spec.tsx.snap | 4 +- .../ButtonsCustomizationPage.spec.tsx.snap | 8 +- .../ColorsComponent.spec.tsx.snap | 8 +- .../__snapshots__/ConsoleHome.spec.tsx.snap | 52 ++---- .../components/PreviewBox/style.scss | 4 +- .../ThemeNavigationPage.spec.tsx.snap | 8 +- .../components/newConsolePage/ConsolePage.tsx | 18 +- .../__snapshots__/ConsolePage.spec.tsx.snap | 164 +++++++----------- .../components/newConsolePage/styles.scss | 15 +- .../CustomizationSideMenu.tsx | 35 ++-- .../CustomizationSideMenu.spec.tsx.snap | 40 ++--- .../newCustomizationSideMenu/styles.scss | 6 +- .../ThemeFooterSideBar.spec.tsx.snap | 8 +- .../components/newFooter/styles.scss | 22 +-- .../App/__snapshots__/App.spec.tsx.snap | 2 +- .../ui/components/ColorInputField/styles.scss | 9 + .../CustomStatusPill/displayMessages.ts | 2 +- .../components/CustomStatusPill/styles.scss | 2 +- frontend/src/ui/components/Header/Header.tsx | 9 +- .../Header/__snapshots__/Header.spec.tsx.snap | 2 +- frontend/src/ui/components/Header/styles.scss | 17 +- 35 files changed, 217 insertions(+), 358 deletions(-) diff --git a/frontend/src/console/components/ConsoleContainer/ConsoleContainer.tsx b/frontend/src/console/components/ConsoleContainer/ConsoleContainer.tsx index bdecbfef3..905491750 100644 --- a/frontend/src/console/components/ConsoleContainer/ConsoleContainer.tsx +++ b/frontend/src/console/components/ConsoleContainer/ConsoleContainer.tsx @@ -4,7 +4,7 @@ import { ConsoleRoutes } from 'routes/console'; import './styles.scss'; export const ConsoleContainer: React.FC = () => ( - + ); diff --git a/frontend/src/console/components/ConsoleContainer/__snapshots__/ConsoleContainer.spec.tsx.snap b/frontend/src/console/components/ConsoleContainer/__snapshots__/ConsoleContainer.spec.tsx.snap index 06d3d63c9..0b7178635 100644 --- a/frontend/src/console/components/ConsoleContainer/__snapshots__/ConsoleContainer.spec.tsx.snap +++ b/frontend/src/console/components/ConsoleContainer/__snapshots__/ConsoleContainer.spec.tsx.snap @@ -2,6 +2,6 @@ exports[`renders without crashing 1`] = `
`; diff --git a/frontend/src/console/components/ConsolePage/__snapshots__/ConsolePage.spec.tsx.snap b/frontend/src/console/components/ConsolePage/__snapshots__/ConsolePage.spec.tsx.snap index 2fa02ba3a..b542b83d4 100644 --- a/frontend/src/console/components/ConsolePage/__snapshots__/ConsolePage.spec.tsx.snap +++ b/frontend/src/console/components/ConsolePage/__snapshots__/ConsolePage.spec.tsx.snap @@ -5,10 +5,10 @@ exports[`Console Page Correctly renders loading page 1`] = ` className="console-page" >
-
- Theme -
+ Theme
-
- Custom Pages -
+ Custom Pages
-
- Instance Settings -
+ Instance Settings
-
- Courses (Studio) -
+ Courses (Studio)
= ({ : handleShowModal; return ( -
-
+ +
= ({ closeMessage={messages.notificationHelp.defaultMessage} messages={messages} /> -
+
); }; diff --git a/frontend/src/console/components/RedeploymentToolbar/__snapshots__/RedeploymentToolbar.spec.tsx.snap b/frontend/src/console/components/RedeploymentToolbar/__snapshots__/RedeploymentToolbar.spec.tsx.snap index 957006623..a5ca3d359 100644 --- a/frontend/src/console/components/RedeploymentToolbar/__snapshots__/RedeploymentToolbar.spec.tsx.snap +++ b/frontend/src/console/components/RedeploymentToolbar/__snapshots__/RedeploymentToolbar.spec.tsx.snap @@ -2,10 +2,10 @@ exports[`RedeploymentToolbar Component Correctly renders redeployment bar when deployment info isn't there 1`] = `
-
- Theme -
+ Theme
-
- Custom Pages -
+ Custom Pages
-
- Instance Settings -
+ Instance Settings
-
- Courses (Studio) -
+ Courses (Studio)
{ if (this.props.showSidebar && !this.props.showSideBarEditComponent) { innerContent = ( - - + + - {innerContent} + + {innerContent} + ); } if (this.props.showSidebar && this.props.showSideBarEditComponent) { innerContent = ( - - + + {renderBackButton(this.props.goBack!)} {innerContent} {/* This is where the preview page component will be redered */} - + @@ -199,7 +201,9 @@ export class ConsolePageComponent extends React.PureComponent {
- {content()} + + {content()} +
diff --git a/frontend/src/newConsole/components/newConsolePage/__snapshots__/ConsolePage.spec.tsx.snap b/frontend/src/newConsole/components/newConsolePage/__snapshots__/ConsolePage.spec.tsx.snap index 27a895445..ec465cbfa 100644 --- a/frontend/src/newConsole/components/newConsolePage/__snapshots__/ConsolePage.spec.tsx.snap +++ b/frontend/src/newConsole/components/newConsolePage/__snapshots__/ConsolePage.spec.tsx.snap @@ -5,10 +5,10 @@ exports[`Console Page Console Page with Edit component Correctly renders loading className="console-page" >
-
- Theme -
+ Theme
-
- Custom Pages -
+ Custom Pages
-
- Instance Settings -
+ Instance Settings
-
- Courses (Studio) -
+ Courses (Studio)
-
- Theme -
+ Theme
-
- Custom Pages -
+ Custom Pages
-
- Instance Settings -
+ Instance Settings
-
- Courses (Studio) -
+ Courses (Studio)
Test! @@ -742,13 +710,13 @@ exports[`Console Page Correctly renders page with email not verified alert 1`] = className="new-console-page-content row" >
-
- Theme -
+ Theme
-
- Custom Pages -
+ Custom Pages
-
- Instance Settings -
+ Instance Settings
-
- Courses (Studio) -
+ Courses (Studio)
Test! diff --git a/frontend/src/newConsole/components/newConsolePage/styles.scss b/frontend/src/newConsole/components/newConsolePage/styles.scss index 5e2b72f52..4a75b5008 100644 --- a/frontend/src/newConsole/components/newConsolePage/styles.scss +++ b/frontend/src/newConsole/components/newConsolePage/styles.scss @@ -6,28 +6,15 @@ flex-direction: column; height: 100% ; .new-console-page-container { - padding: 3rem 1rem; - margin: 0 -15px; + padding: 3rem 0; flex: 1; .new-console-page-content { - height: 100%; - - .console-page-inner-content { - height: 100%; - } - } - - .console-page-content { margin: 0 auto; - max-width: 1100px; justify-content: center; flex-grow: 1; .customization-form { - background-color: #f0f5f7; - padding: 32px; - margin-bottom: 16px; .loading { text-align: center; diff --git a/frontend/src/newConsole/components/newCustomizationSideMenu/CustomizationSideMenu.tsx b/frontend/src/newConsole/components/newCustomizationSideMenu/CustomizationSideMenu.tsx index 530cc4524..3fe451110 100644 --- a/frontend/src/newConsole/components/newCustomizationSideMenu/CustomizationSideMenu.tsx +++ b/frontend/src/newConsole/components/newCustomizationSideMenu/CustomizationSideMenu.tsx @@ -41,11 +41,9 @@ export const CustomizationSideMenu: React.FC = () => { className="new-customization-menu" > - - - - - + + +
+ ); }; diff --git a/frontend/src/ui/components/Header/__snapshots__/Header.spec.tsx.snap b/frontend/src/ui/components/Header/__snapshots__/Header.spec.tsx.snap index 5efb85870..12d21c6d9 100644 --- a/frontend/src/ui/components/Header/__snapshots__/Header.spec.tsx.snap +++ b/frontend/src/ui/components/Header/__snapshots__/Header.spec.tsx.snap @@ -5,7 +5,7 @@ exports[`renders without crashing 1`] = ` className="navbar navbar-expand-md navbar-dark" >