feat: allow oauth configuration per site and backend #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navinkarkera
force-pushed
the
navin/multisite-oauth-config
branch
from
74d2168
to
38b6bd9
Compare
|
@navinkarkera, please add a ticket number to this PR. |
|
@Agrendalath Done. |
|
Hey @navinkarkera, will you be opening a PR against upstream master with these changes? |
|
@itsjeyd I am not sure whether we should upstream this. I think it would be useful. @kaustavb12 What do you think? |
If we don't have a very good reason not to upstream it - yes, we should. Otherwise, we should look for another way to implement this - e.g., as a plugin/extension. |
Allows admins to configure same oauth backend for multiple sites
navinkarkera
force-pushed
the
navin/multisite-oauth-config
branch
from
9f55ee9
to
ec738bc
Compare
|
@Agrendalath I'll create a PR against master and wait for upstream reviewers comments. |
kaustavb12
requested changes
Jul 6, 2023
|
@navinkarkera I don't see a reason not to upstream this. |
navinkarkera
force-pushed
the
navin/multisite-oauth-config
branch
from
28bafb3
to
7bbe8e8
Compare
kaustavb12
approved these changes
Jul 7, 2023
kaustavb12
added a commit
that referenced
this pull request
Aug 15, 2023
* feat: allow oauth configuration per site and backend Allows admins to configure same oauth backend for multiple sites (cherry picked from commit efd2ef9) * fix: skip pipeline if oauth provider for site is not setup (cherry picked from commit 29f8494) * refactor: remove site_id from provider_id (cherry picked from commit 236f7a5) --------- Cherry pick of #542 Upstream PR openedx#32656 [BB-7589](https://tasks.opencraft.com/browse/BB-7589) --------- Co-authored-by: Navin Karkera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows admins to configure same oauth backend for multiple sites.
Private-ref: BB-7589