fix: display right-to-left for rtl-languages in mobile - #406
Closed
meysam81 wants to merge 2 commits into
Closed
Conversation
|
@meysam81, I think the proper thing to do is the following - diff --git a/lms/static/sass/_header.scss b/lms/static/sass/_header.scss
index aa4236fd74..1949d557de 100644
--- a/lms/static/sass/_header.scss
+++ b/lms/static/sass/_header.scss
@@ -366,7 +366,7 @@
width: 100%;
padding: $baseline*0.6 $baseline;
border-bottom: 1px solid theme-color('light');
- text-align: left;
+ @include text-align(left);
cursor: pointer;
&:hover,This fixed the issue for me and didn't give any error. Can you try this? |
Author
|
Closing in favor of edx/edx-platform#28861 cc @shimulch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will display the RTL languages from right to left. Tested on mobile using Developer Tools on Firefox.
To reproduce the result in this PR, simply run the devstack on
koa.master, open the Developer Tools on either Firefox or Chrome, select Mobile View from the icon on the top right of the Developer Tools, check the display when the following settings are applied:You can optionally change the theme for more thorough testing, though it's not necessary; By copying a theme like nelp to
<devstack_root>/../srcand with the following change:Then head to http://localhost:18000 and check the changes to see if an RTL language (like Arabic:
ar) is correctly displayed from right to left or not.