Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Visual improvements #34

Open
jpmckinney opened this issue Jul 9, 2019 · 2 comments
Open

PDF: Visual improvements #34

jpmckinney opened this issue Jul 9, 2019 · 2 comments

Comments

@jpmckinney
Copy link
Member

See open-contracting/standard#588 (comment)

Once those are made, we can fold this repo into the standard repo, and make generating PDFs part of the build process.

We are not married to wkhtmltopdf as the solution, but it seems to be the best option so far. Other options are Sphinx and Chrome (follow link in open-contracting/standard#588 issue description).

@jpmckinney jpmckinney changed the title Visual improvements PDF: Visual improvements Jan 22, 2020
@jpmckinney jpmckinney transferred this issue from open-contracting-archive/ocds-pdf Jan 22, 2020
@jpmckinney
Copy link
Member Author

Noting that:

tr {
  page-break-inside: avoid;
}

doesn't seem to fix the issue in the GPA profile of rows breaking. But this should work according to wkhtmltopdf/wkhtmltopdf@5dea253

@jpmckinney
Copy link
Member Author

jpmckinney commented Sep 19, 2020

We should also test/look into options for letting Sphinx build the PDF(s) itself.

See also https://jupyterbook.org/advanced/pdf.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant