Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the submissionTerms extension #1183

Closed
ColinMaudry opened this issue Jan 25, 2021 · 9 comments · Fixed by #1654
Closed

Merge the submissionTerms extension #1183

ColinMaudry opened this issue Jan 25, 2021 · 9 comments · Fixed by #1654
Assignees
Labels
Focus - Extensions Relating to new or proposed extensions, or the governance and maintenance of extensions Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Milestone

Comments

@ColinMaudry
Copy link
Member

We can consider merging the submission terms extension into core. That extension supports the only clear use case from the discussion in #322, which is distinguishing opportunities for which electronic submission is required/allowed/not allowed.

#322 (comment)

submissionTerms extension

@ColinMaudry ColinMaudry added the Schema: Fields Relating to adding or deprecating fields in the JSON Schema label Jan 25, 2021
@ColinMaudry ColinMaudry added this to the 1.2.0 milestone Jan 25, 2021
@ColinMaudry ColinMaudry self-assigned this Jan 25, 2021
@jpmckinney jpmckinney changed the title submissionTerms extension: merge into core? Move submissionTerms into release schema Jan 26, 2021
@ColinMaudry
Copy link
Member Author

ColinMaudry commented Jan 26, 2021

If the submissionTerms extension ends up being added in core:

@ColinMaudry
Copy link
Member Author

The description could look like this (inspired by the description of Budget.source:

The submission method field used unclear or irrelevant codes. As a result, it has been deprecated in version 1.2. The submission terms field (tender.submissionTerms) can be used to describe the electronic submission policy of the procedure.

@ColinMaudry
Copy link
Member Author

ColinMaudry commented Jan 26, 2021

It would be sensible to move submissionMethodDetails to submissionTerms if it ends up being added to core (cf #322 (comment)).

I mean depracating submissionMethodDetails and adding it to SubmissionTerms. However that might not be feasible in a minor version. It may be simpler to wait for 2.0.

@jpmckinney
Copy link
Member

submissionMethodDetails is a top 100 field according to this sheet.

The submissionTerms extension doesn't have a description field like other extensions, like bidOpening, because submissionMethodDetails already existed.

I don't think the benefit of a predictable field path outweighs the cost of a deprecated field. So, I would prefer to create a 2.0 issue if this issue is closed.

@jpmckinney jpmckinney added the Focus - Extensions Relating to new or proposed extensions, or the governance and maintenance of extensions label Jun 7, 2023
@jpmckinney
Copy link
Member

jpmckinney commented Jun 7, 2023

When merging into OCDS, we should review field titles/descriptions against the style guide (as part of #850). I think it conforms since it is a recent extension, but we can do a quick check.

Also, we should rename electronicCataloguePolicy to electronicCatalogPolicy. We will need to notify the UK and Scotland about this when contacting them about the OCDS 1.2 upgrade.

And, we should close this issue: open-contracting/ocds-extensions#169

@jpmckinney jpmckinney changed the title Move submissionTerms into release schema Merge the submissionTerms extension Jun 7, 2023
@jpmckinney
Copy link
Member

Submission terms has many fields now that might only be used in the EU.

The reason for merging this extension was to offer to migrate the 'electronicSubmission' code from the deprecated submissionMethod field to the new electronicSubmissionPolicy field.

I think we should only merge that field.

We can make a 1.2 version of the extension that removes this field.

@odscjen
Copy link
Contributor

odscjen commented Oct 17, 2023

So we're just moving submissionTerms.electronicSubmissionPolicy?

Noting that this will need to be moved into the Lots extension as well in this case.

@jpmckinney

@jpmckinney
Copy link
Member

Hmm, let's maybe keep the field in the extension, while adding it to 1.2. Users of 1.2 and of that extension will cause the extension to overwrite the 1.2 field, but we can commit to keeping them in sync. That way we don't have to change lots and have multiple versions of the extensions for 1.1 and 1.2.

@jpmckinney
Copy link
Member

Created follow-up issue for Lots: open-contracting/ocds-extensions#212

@jpmckinney jpmckinney moved this to Done in OCDS 1.2 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus - Extensions Relating to new or proposed extensions, or the governance and maintenance of extensions Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants