-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the submissionTerms extension #1183
Comments
If the submissionTerms extension ends up being added in core:
|
The description could look like this (inspired by the description of
|
It would be sensible to move I mean depracating |
The submissionTerms extension doesn't have a I don't think the benefit of a predictable field path outweighs the cost of a deprecated field. So, I would prefer to create a 2.0 issue if this issue is closed. |
When merging into OCDS, we should review field titles/descriptions against the style guide (as part of #850). I think it conforms since it is a recent extension, but we can do a quick check. Also, we should rename And, we should close this issue: open-contracting/ocds-extensions#169 |
Submission terms has many fields now that might only be used in the EU. The reason for merging this extension was to offer to migrate the 'electronicSubmission' code from the deprecated I think we should only merge that field. We can make a 1.2 version of the extension that removes this field. |
So we're just moving Noting that this will need to be moved into the Lots extension as well in this case. |
Hmm, let's maybe keep the field in the extension, while adding it to 1.2. Users of 1.2 and of that extension will cause the extension to overwrite the 1.2 field, but we can commit to keeping them in sync. That way we don't have to change lots and have multiple versions of the extensions for 1.1 and 1.2. |
Created follow-up issue for Lots: open-contracting/ocds-extensions#212 |
#322 (comment)
submissionTerms extension
The text was updated successfully, but these errors were encountered: