Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field checks: Display values in the quality failure samples table #50

Open
duncandewhurst opened this issue Mar 26, 2020 · 6 comments
Open
Labels
field checks Relating to field-level check pages
Milestone

Comments

@duncandewhurst
Copy link

For fields which aren't objects or arrays it would be useful to see the actual value for each of the examples in the samples of successes/failures table, so we don't have to open multiple JSON previews to view the individually.

Basically, I mean adding a 'value' column to this table:

image

@jpmckinney
Copy link
Member

This could work for field-level checks.

@hrubyjan
Copy link

hrubyjan commented Jul 9, 2021

@duncandewhurst @jpmckinney
Is this still relevant or how this should work?

I mean this make sense to me basically only for field level quality checks.

Filed level - is set? - nothing can be displayed when it's not set as the key is missing. When it's set then it's some random value
Field level - is null or empty? - either null or empty string. Or again some random value
Field level - quality? - make sense for failures. But even here imagine for example description longer then 250 characters that should nicely fit into the table

Resource level - there is always more information that needs to be displayed no simple value

Collection level - it can make sense to display the values for Value distribution checks but not for the rest. And here is no need to open multiple jsons as the the examples are in the metadata which are static for each check or even the values are headers of tables (for distribution checks like currency, status, 'procurememntCategory' , ...)

@jpmckinney
Copy link
Member

jpmckinney commented Jul 9, 2021

I think the idea was to display something for field-level quality failures. If the description is too long, we can truncate it in the table - so in that case, the user might still need to open the example. For numbers, etc., it is fine.

The issue description also mentions examples for quality successes, but I am not sure in what scenario we want to look at good values.

@duncandewhurst
Copy link
Author

I think the idea was to display something for field-level quality failures.

Yes, that's correct.

The issue description also mentions examples for quality successes, but I am not sure in what scenario we want to look at good values.

In general, it might help to put the failures in context and give some insight into whether the cause is a mapping error or a quality issue in the data source. However, looking at the list of field-level quality checks, I'm not sure it's relevant to the checks we have right now.

@jpmckinney jpmckinney transferred this issue from open-contracting-archive/pelican Sep 14, 2021
@jpmckinney jpmckinney added the field checks Relating to field-level check pages label Sep 14, 2021
@jpmckinney
Copy link
Member

Sibling issue for compiled release checks: #49

@jpmckinney
Copy link
Member

jpmckinney commented Sep 14, 2021

Merging #51:

Title: Show/export list of unrecognized party identifier schemes

It would be helpful to get a deduplicated list of the identifier schemes which failed the check, so we can report these to the publisher.

Note that #51 also discusses whether to add this as a dataset-level check in order to get a comprehensive list of invalid schems, but we can first report the values in the samples at the field-level.

@jpmckinney jpmckinney added this to the Priority milestone Dec 1, 2021
@jpmckinney jpmckinney changed the title Report the actual values in the sample of success/failures tables Field checks: Display values in the sample of failures table Aug 11, 2023
@jpmckinney jpmckinney changed the title Field checks: Display values in the sample of failures table Field checks: Display values in the quality failure samples table Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field checks Relating to field-level check pages
Projects
None yet
Development

No branches or pull requests

3 participants