-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: Option to group field check results thematically #37
Comments
Are you thinking this might be a view you toggle into? For example, there's currently a toggle at the top-right of the field table to nest fields or not. |
Yep, a toggle for group by field / group by check type sounds good. |
@duncandewhurst Could you describe the groups you would want? Once we have that, we can plan the changes. |
The main one I had in mind was to group all the 'Date is realistic' checks in one place. But it would be helpful to group any other checks which are applied to multiple fields, e.g. 'Document type is coherent' and 'Has 250 characters or less'. I picked those examples by looking at the check results for the latest Moldova collection, but there could be others depending on which fields are included in a collection. Is there a full list of checks I can review somewhere? |
Here's a list of checks that I exported from Pelican. I can reformat the output as a spreadsheet with more detail on field paths for field-level checks. Let me know if you prefer that. In most cases, for now, you can sort by quality and use the filter text box to search for "document" or "period", and the matching checks will be at the top of the list. In any case, for field-level checks, I think it should be fairly straight forward to group by check type (Document type is coherent, etc.). |
Thanks! From that list, I think 'Document format is recognized' and 'Number is non-negative' are the other useful ones to group by. |
For example, in the Data Feedback Notebook there is a check for unlikely dates which checks the
.startDate
and.endDate
fields intender.tenderPeriod
,tender.enquiryPeriod
,tender.awardPeriod
andtender.contractPeriod
.In Pelican the same check is split across 8 different individual checks.
When sharing feedback with publishers it would be useful to group results where the same check is applied across different fields, e.g. summary of all checks for non-negative numbers, summary of all checks for realistic dates etc.
The text was updated successfully, but these errors were encountered: