Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

character varying (CharField) and jsonb (JSONField) fields should be NOT NULL #87

Open
jpmckinney opened this issue Jul 4, 2023 · 0 comments
Labels
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Jul 4, 2023

Similar to https://ocp-software-handbook.readthedocs.io/en/latest/python/django.html#models

  • dataset.meta
  • dataset_filter.filter_message
  • report.data
  • data_item.data
  • field_level_check.result
  • field_level_check_examples.data
  • resource_level_check.result
  • resource_level_check_examples.data
  • dataset_level_check.meta
  • time_variance_level_check.meta

In pelican-frontend:

  • change null=True to default=dict for FieldLevelCheck.data and ResourceLevelCheckExamples.data.
  • remove null=True from CharField
  • Remove # noqa: DJ001

Consider doing #112 at same time.

@jpmckinney jpmckinney added this to the Cleanup milestone Aug 11, 2023
@jpmckinney jpmckinney added chore and removed chore labels Feb 6, 2024
@jpmckinney jpmckinney removed the quick label May 22, 2024
@jpmckinney jpmckinney changed the title jsonb fields should be NOT NULL character varying (CharField) and jsonb (JSONField) fields should be NOT NULL Sep 5, 2024
jpmckinney added a commit to open-contracting/pelican-frontend that referenced this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant