-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots: List fields with different semantics between tender and tender.lots #198
Comments
So |
Hmm, the comments about semantic difference in #40 were concerning this new paragraph in the guidance (note: "Usage guidance" in that issue refers to the "Guidance" section of the readme):
When I wrote:
I meant to say "tender.value is the estimated value of the procurement (i.e. greater than any individual lot). Lot.value is the estimated value of the lot. These mean different things, because one refers to the procurement and the other refers to the lot. Therefore, the relevant data element from the data source cannot possibly be mapped to either one or the other. It can only be mapped to one." It is not just the fact that lot mentions "maximum". So, for example, the status fields are semantically different. The readme even has a section to explain the difference. Here's the issue: In OCDS, there are no lots. If we had added lots to OCDS from the beginning, some fields on The guidance "you should nonetheless add a single, virtual lot" is about encouraging publishers to implement OCDS as if we had added lots to OCDS from the beginning. To do that, we either need:
The second option is what I was discussing in my quoted comment. But, it might be the case that the first option is simpler or clearer. From a very quick assessment: Lists left in
Fields that do belong on tender:
And that don't belong on tender:
Unclear or unknown, but probably don't belong on tender:
For all this, it'd be very useful to compare to eForms, to see where fields are allowed on both the procedure and lot, or only on one or the other (i.e. the -Procedure and -Lot suffixes to field names). Something that can lead to confusion is that, in some jurisdictions, some fields might never differ across lots in any contracting process (e.g. maybe a jurisdiction never has a contracting process for multiple framework agreements, and so Lot.techniques is useless repetition). I don't know if we want to special-case that. Maybe it's a point for consultation.
I think this is badly worded (from the very first version of the extension). In any case, it will be deprecated in favor of finalStatus, etc. open-contracting-extensions/ocds_lots_extension#51 |
From open-contracting-extensions/ocds_lots_extension#40 (comment):
The text was updated successfully, but these errors were encountered: