Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-from-ocds: add location ids in transform #8

Open
pindec opened this issue Feb 25, 2021 · 0 comments
Open

convert-from-ocds: add location ids in transform #8

pindec opened this issue Feb 25, 2021 · 0 comments

Comments

@pindec
Copy link

pindec commented Feb 25, 2021

The project location transform currently doesn't add any id fields, so the OC4IDS DRT reports a structural error on output with locations since id is required.

  • From OCDS, location is inferred from any existing item/deliveryLocation fields from the Location extension. Since there is only one deliveryLocation per item, there are no id fields in source data, but there may be multiple items with a deliveryLocation within a tender in source OCDS data.
  • From OCDS for PPPs, location objects are copied from /planning/project/locations from the Projects extension, which also don't haveid fields.

The conversion script should generate location ids.

Related issue on adding more tests for location: #3

@jpmckinney jpmckinney transferred this issue from open-contracting/ocdskit May 19, 2021
@jpmckinney jpmckinney changed the title convert-to-oc4ids: add location ids in transform convert-from-ocds: add location ids in transform May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant