Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert-from-ocds: expand procuring_entity function #1

Open
pindec opened this issue Mar 2, 2021 · 1 comment
Open

convert-from-ocds: expand procuring_entity function #1

pindec opened this issue Mar 2, 2021 · 1 comment

Comments

@pindec
Copy link

pindec commented Mar 2, 2021

The current procuring_entity function only copies across parties with a role of "procuringEntity".

It should also check whether tender.procuringEntity.name and tender.procuringEntity.id exist as outlined in the mapping to cover cases where tender.procuringEntity fields are declared, but the roles for that party do not include "procuringEntity", as in the OCDS sample data.

https://github.com/open-contracting/ocdskit/blob/9255880b2e5bda334b4e0e61cd5ecc327aab3c5f/ocdskit/oc4ids.py#L392
@duncandewhurst
Copy link
Contributor

@pindec please could you open an issue on the sample data repo to add the 'procuringEntity' role.

@jpmckinney jpmckinney transferred this issue from open-contracting/ocdskit May 19, 2021
@jpmckinney jpmckinney changed the title convert-to-oc4ids: expand procuring_entity function convert-from-ocds: expand procuring_entity function May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pindec @duncandewhurst