Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include context of errors (e.g. reporting the OCID) #39

Open
mrshll1001 opened this issue May 7, 2020 · 2 comments
Open

Include context of errors (e.g. reporting the OCID) #39

mrshll1001 opened this issue May 7, 2020 · 2 comments
Labels
triage The appropriate label and repository is not yet determined

Comments

@mrshll1001
Copy link

From a helpdesk issue

Currently when reporting structural errors the review tool reports the location of the error relative to the package e.g. releases/38/tender/tenderers. Since some packages are generated on the fly, and there may be complex mapping behind them, it may be helpful if it would also extract the OCID of the release with the issue rather than just its position in the array. This would support the publisher finding the offending release elsewhere to make the change.

@jpmckinney jpmckinney added the check results Relating to how specific checks are reported label Sep 2, 2020
@robredpath robredpath changed the title Include OCID of errors Include context of errors (eg OCID) Sep 23, 2020
@robredpath
Copy link
Contributor

Just linking up to OpenDataServices/cove#167 where this was discussed in 2015(!)

An addition/alternative might be to provide line numbers for the JSON file. I suspect that ocid is actually easier, but I'm not sure!

@dwasyl
Copy link

dwasyl commented Sep 28, 2020

For what it's worth, reporting the release id would be a lot more useful (at least to me) than a JSON line number.

The current data is okay, and I've handled it by converting the JSON to a spreadsheet and then finding the line number (since the package was dynamically generated), but that's not ideal.

@jpmckinney jpmckinney changed the title Include context of errors (eg OCID) Include context of errors (e.g. reporting the OCID) Oct 14, 2020
@jpmckinney jpmckinney added triage The appropriate label and repository is not yet determined and removed check results Relating to how specific checks are reported labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage The appropriate label and repository is not yet determined
Projects
None yet
Development

No branches or pull requests

4 participants