Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore buyer and suppliers fields #236

Closed
jpmckinney opened this issue Nov 16, 2020 · 7 comments · Fixed by #243
Closed

Restore buyer and suppliers fields #236

jpmckinney opened this issue Nov 16, 2020 · 7 comments · Fixed by #243

Comments

@jpmckinney
Copy link
Member

These are renamed to publicAuthority and preferredBidders. This makes OCDS for PPPs data unnecessarily incompatible with OCDS data. The original terms are inappropriate, but this needs to be fixed in an OCDS 2.0, not in a profile. For OCDS 1.2, the fix is to broaden the definitions of buyer and suppliers, while retaining the terms.

@jpmckinney
Copy link
Member Author

cc @duncandewhurst

@duncandewhurst
Copy link
Member

Agreed, sounds good.

@jpmckinney
Copy link
Member Author

@duncandewhurst Since OCDS for PPPs is relevant to a few active implementers, and since you might be making changes to close #238, could you take on this issue, #237 and ideally #217 ?

@duncandewhurst
Copy link
Member

Sure, should I prioritise those above 1.2 issues?

@jpmckinney
Copy link
Member Author

Yes, looks like Matt, Kadie and Charlie have taken on enough 1.2 issues for now.

@duncandewhurst
Copy link
Member

@jpmckinney a couple of questions on your preferred approach:

  • Should we remove publicAuthority and preferredBidders completely, or should we deprecate them?

  • Should we also remove/restore the associated codes in partyRole.csv?

@jpmckinney
Copy link
Member Author

Should we remove publicAuthority and preferredBidders completely, or should we deprecate them?

Since the profile isn't 1.0 but is beta, I think better to remove.

Should we also remove/restore the associated codes in partyRole.csv?

Yes, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants