Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deliveryAddresses #4

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Added deliveryAddresses #4

merged 7 commits into from
Apr 29, 2020

Conversation

ColinMaudry
Copy link
Contributor

I have also updated the sample JSON and the BT/BG list.

@ColinMaudry
Copy link
Contributor Author

Implements the feature discussed here: open-contracting/european-union-support#19

@ColinMaudry
Copy link
Contributor Author

ColinMaudry commented Apr 29, 2020 •
edited
Loading

I can delete the deliveryAddresses repo, right?

Edit : ah no, don't have the rights :) https://github.com/open-contracting-extensions/ocds_deliveryAddresses_extension/settings

jpmckinney
jpmckinney reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple copy-edits. I've deleted the other repo.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

Oh, we also added a new contactPoint field to all extension.json. You can copy for example: https://github.com/open-contracting-extensions/ocds_lots_extension/blob/master/extension.json#L21

ColinMaudry
ColinMaudry commented Apr 29, 2020
View reviewed changes
Copy link
Contributor Author

@ColinMaudry ColinMaudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@jpmckinney jpmckinney merged commit 0f9a4a4 into master Apr 29, 2020
@jpmckinney jpmckinney deleted the develop branch April 29, 2020 19:00
@jpmckinney jpmckinney mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinMaudry @jpmckinney