Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F14: Update guidance #63

Closed
jpmckinney opened this issue Mar 18, 2020 · 3 comments
Closed

F14: Update guidance #63

jpmckinney opened this issue Mar 18, 2020 · 3 comments
Assignees

Comments

@jpmckinney
Copy link
Member

Background

  • /CHANGES/CHANGE/WHERE/SECTION and /CHANGES/CHANGE/WHERE/LABEL can refer to non-existent sections or labels.
  • /CHANGES/CHANGE/WHERE/SECTION and /CHANGES/CHANGE/WHERE/LABEL can refer to existing sections and labels, but can be incorrect.
  • Some elements on other forms are unlabeled, so /CHANGES/CHANGE/WHERE can't deterministically identify the element to update.
  • The type of /CHANGES/CHANGE/NEW_VALUE can be inconsistent with the type of the element (e.g. TEXT for a CPV code).
    - /CHANGES/CHANGE/NEW_VALUE/TEXT can be incomplete (e.g. a description of changes, rather than a new copy of the updated text).

Discussion

The options are:

  1. Where possible, follow the current approach (i.e. overwrite fields). If not possible due to above issues, describe the changes in new fields in the Amendment object.
  2. Always describe the changes in new fields in the Amendment object.

Regarding (1), I'm concerned about an inconsistent approach. In particular, if there are multiple F14 notices for a contracting process, it will be very confusing to a user if the same field is updated sometimes in-place and sometimes in amendments.

As noted by @ColinMaudry, our approach would ideally be informed by actual error rates. For example, if error rates are low, (1) would have better data quality with only few inconsistencies in approach.

Proposal

Until we get data on error rates, we should take the conservative approach (2).

We should also indicate that publishers should describe the use of Amendment objects in their publication policy (and share the link to the template). (This policy should also link to the OCDS for EU profile, and identify the version in use.)

As a separate note, we should indicate that, if an OCDS release exists for the given ocid, that mapping sections I and II on F14 is optional.

@ColinMaudry
Copy link

ColinMaudry commented Mar 19, 2020

OK with the proposal to start with a conservative approach:

  1. Always describe the changes in new fields in the Amendment object.

I start working on it today, with the mapping and guidance. The OCDS extension will follow afterward.

@jpmckinney
Copy link
Member Author

I've merged your PR, updated the changelog, and rebuilt the docs.

@ColinMaudry
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants