Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Finish adding docstrings and checking logic #50

Open
7 of 8 tasks
jpmckinney opened this issue Oct 27, 2020 · 2 comments
Open
7 of 8 tasks

Finish adding docstrings and checking logic #50

jpmckinney opened this issue Oct 27, 2020 · 2 comments
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Oct 27, 2020

  • archive: should_archive
  • s3

Check logic against:

Check logic (in lib and tests) against Google doc:

  • Working out what to do for a collection
  • Test Scenarios for “Working out what to do for a collection”
  • Dealing with data already on the archive server
  • Removing old backups to get down to one per year later
  • How to identify the correct log for a crawl?
jpmckinney added a commit that referenced this issue Oct 29, 2020
…ename is_subset to is_subset to is_complete. Add docstring to should_archive #50. Return value from process_crawl.
@jpmckinney jpmckinney changed the title Finish adding docstrings Finish adding docstrings and checking logic Oct 29, 2020
@jpmckinney jpmckinney added this to the 1.0 milestone May 5, 2021
@jpmckinney
Copy link
Member Author

Need to review and/or move and/or document write_meta_data_file and write_data_file.

@jpmckinney
Copy link
Member Author

Should consider splitting the run method into smaller methods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant