-
Notifications
You must be signed in to change notification settings - Fork 14
.gitmodules cleanup #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.gitmodules cleanup #448
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 55 55
Lines 2516 2516
Branches 142 142
=======================================
Hits 2280 2280
Misses 163 163
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [submodule "."] | ||
| branch = pypartmc | ||
| [submodule "nanobind_json"] | ||
| branch = pypartmc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't nanobind_json submodule stay at pypartmc branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, let's introduce a test that fails otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyPartMC/tests/test_aero_mode.py
Line 317 in d1c9eb4
| def test_fixed_segfault_case_on_circular_reference(): |
This test should fail due to circular reference - it fails on my machine. Looking at the main branch of
nanobind_json, it shouldn't be even able to compile due to compatibility errors with current nanobind. But it seems that everything worked on CI (could it somehow pulled the "old" submodules?).
Regardless, soon enough we should be able to use the main branch of nanobind_json ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the branch option is only used for submodule updates, while even without specifying it the commit hash registered during last commit points to the specific version of the submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, then it's okay!
No description provided.