Skip to content

Conversation

@slayoo
Copy link
Member

@slayoo slayoo commented Sep 12, 2025

No description provided.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (1166864) to head (84da001).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          55       55           
  Lines        2516     2516           
  Branches      142      142           
=======================================
  Hits         2280     2280           
  Misses        163      163           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo slayoo requested a review from Griger5 September 12, 2025 07:34
[submodule "."]
branch = pypartmc
[submodule "nanobind_json"]
branch = pypartmc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't nanobind_json submodule stay at pypartmc branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if so, let's introduce a test that fails otherwise!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def test_fixed_segfault_case_on_circular_reference():

This test should fail due to circular reference - it fails on my machine. Looking at the main branch of nanobind_json, it shouldn't be even able to compile due to compatibility errors with current nanobind. But it seems that everything worked on CI (could it somehow pulled the "old" submodules?).

Regardless, soon enough we should be able to use the main branch of nanobind_json ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the branch option is only used for submodule updates, while even without specifying it the commit hash registered during last commit points to the specific version of the submodule

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, then it's okay!

@Griger5 Griger5 self-requested a review September 16, 2025 10:11
@slayoo slayoo merged commit 2e8ed4b into main Sep 16, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants