Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

When will this support React 0.16 #10

Open
kotay opened this issue Jun 21, 2017 · 7 comments
Open

When will this support React 0.16 #10

kotay opened this issue Jun 21, 2017 · 7 comments

Comments

@kotay
Copy link

kotay commented Jun 21, 2017

Integration with a React 0.16 app currently crashes the app.

@hmdhk
Copy link
Contributor

hmdhk commented Jun 21, 2017

Thanks for reporting the issue @kotay ,

Do you see any errors in your console?

@bjudson
Copy link

bjudson commented Oct 2, 2017

Now that React 16 is out of beta, might be a good time to address this issue. The error I'm seeing in the console with React 16 and opbeat-react 3.4.0 is:

patchUtils.js:51 Uncaught TypeError: Cannot read property 'mountComponent' of undefined
    at r (patchUtils.js:51)
    at e.exports (reactPatches.js:41)
    at react.js:59
    at Object.ready (reactInternals.js:24)
    at r (react.js:58)
    ...

@hmdhk
Copy link
Contributor

hmdhk commented Oct 3, 2017

Thanks for the update @bjudson ,

Currently we're making some structural improvements to our module which will give developers more flexibility going forward. However this would be a priority for us once these improvements are finished.

I will make sure to update this issue about our progress.

Cheers

@danieljuhl
Copy link

@jahtalab any news on this one?

@hmdhk
Copy link
Contributor

hmdhk commented Nov 23, 2017

Related #19

@igoldny
Copy link

igoldny commented Dec 4, 2017

@jahtalab it's not related to React Router 4.
I'm using React Router 3 + React 16 and I get the same error.

@hmdhk
Copy link
Contributor

hmdhk commented Dec 4, 2017

Thanks @igoldny for the info.

We should also keep track of necessary fixes that are needed to support the latest versions in our opbeat-react module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants