From 178600d6198fd3cbba69741c1c9921c2e3e8c942 Mon Sep 17 00:00:00 2001
From: clabby <ben@clab.by>
Date: Sun, 28 Apr 2024 15:34:46 -0400
Subject: [PATCH] chore(workspace): Exclude all crates except `kona-common`
 from cannon/asterisc lint job

Optimizes the lint jobs by only including the crates with
architecture-specific code (`kona-common`) in the `lint-asterisc` and
`lint-cannon` recipes. All other crates will be linted entirely with the
native lint recipe.

We still include all `no_std` crates in the `build` recipes for `cannon`
/ `asterisc` targets, as these crates still need build coverage to
ensure that they always compile to our required targets.
---
 justfile | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/justfile b/justfile
index e25dbbf5cd..2f15f2f92d 100644
--- a/justfile
+++ b/justfile
@@ -7,9 +7,9 @@ default:
 # Run all tests
 tests: test test-online test-docs
 
-# Test for the native target
+# Test for the native target with all features
 test *args='':
-  cargo nextest run --workspace --all --all-features  $@
+  cargo nextest run --workspace --all --all-features $@
 
 # Run online tests
 test-online:
@@ -30,23 +30,23 @@ fmt-native-check:
 lint-native: fmt-native-check
   cargo +nightly clippy --workspace --all --all-features --all-targets -- -D warnings
 
-# Lint the workspace (mips arch)
+# Lint the workspace (mips arch). Currently, only the `kona-common` crate is linted for the `cannon` target, as it is the only crate with architecture-specific code.
 lint-cannon:
   docker run \
     --rm \
     --platform linux/amd64 \
     -v `pwd`/:/workdir \
     -w="/workdir" \
-    ghcr.io/ethereum-optimism/kona/cannon-builder:main cargo +nightly clippy --workspace --all --all-features --target /mips-unknown-none.json -Zbuild-std --exclude kona-derive --exclude kona-host -- -D warnings
+    ghcr.io/ethereum-optimism/kona/cannon-builder:main cargo +nightly clippy -p kona-common --all-features --target /mips-unknown-none.json -Zbuild-std -- -D warnings
 
-# Lint the workspace (risc-v arch)
+# Lint the workspace (risc-v arch). Currently, only the `kona-common` crate is linted for the `asterisc` target, as it is the only crate with architecture-specific code.
 lint-asterisc:
   docker run \
     --rm \
     --platform linux/amd64 \
     -v `pwd`/:/workdir \
     -w="/workdir" \
-    ghcr.io/ethereum-optimism/kona/asterisc-builder:main cargo +nightly clippy --workspace --all --all-features --target riscv64gc-unknown-linux-gnu -Zbuild-std --exclude kona-derive -- -D warnings
+    ghcr.io/ethereum-optimism/kona/asterisc-builder:main cargo +nightly clippy -p kona-common --all-features --target riscv64gc-unknown-linux-gnu -Zbuild-std -- -D warnings
 
 # Lint the Rust documentation
 lint-docs:
@@ -63,7 +63,7 @@ build: build-native build-cannon build-asterisc
 build-native *args='':
   cargo build --workspace --all $@
 
-# Build for the `cannon` target
+# Build for the `cannon` target. Any crates that require the stdlib are excluded from the build for this target.
 build-cannon *args='':
   docker run \
     --rm \
@@ -72,7 +72,7 @@ build-cannon *args='':
     -w="/workdir" \
     ghcr.io/ethereum-optimism/kona/cannon-builder:main cargo build --workspace --all -Zbuild-std $@ --exclude kona-host
 
-# Build for the `asterisc` target
+# Build for the `asterisc` target. Any crates that require the stdlib are excluded from the build for this target.
 build-asterisc *args='':
   docker run \
     --rm \