Skip to content

Commit 563cf5f

Browse files
authored
Upgrade ESM (mapbox#6750)
* upgrade esm * temporary hack for whoots-js exports
1 parent e8bc616 commit 563cf5f

File tree

8 files changed

+14
-17
lines changed

8 files changed

+14
-17
lines changed

build/rollup_plugins.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ export const plugins = () => [
3030
}),
3131
commonjs({
3232
namedExports: {
33-
'@mapbox/gl-matrix': ['vec3', 'vec4', 'mat2', 'mat3', 'mat4']
33+
'@mapbox/gl-matrix': ['vec3', 'vec4', 'mat2', 'mat3', 'mat4'],
34+
'@mapbox/whoots-js': ['getTileBBox']
3435
}
3536
}),
3637
production ? uglify() : false

build/run-node

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#!/usr/bin/env bash
22

3-
node -r @mapbox/flow-remove-types/register -r @std/esm ${@}
3+
node -r @mapbox/flow-remove-types/register -r esm ${@}

build/run-tap

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ else
55
arg="${@}"
66
fi
77

8-
node_modules/.bin/tap --node-arg -r --node-arg @mapbox/flow-remove-types/register --node-arg -r --node-arg @std/esm $arg
8+
node_modules/.bin/tap --node-arg -r --node-arg @mapbox/flow-remove-types/register --node-arg -r --node-arg esm $arg --node-arg

package.json

+2-6
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"@mapbox/flow-remove-types": "^1.3.0-await.upstream.1",
4646
"@mapbox/mapbox-gl-rtl-text": "^0.1.2",
4747
"@mapbox/mapbox-gl-test-suite": "file:test/integration",
48-
"@std/esm": "^0.21.7",
4948
"babel-eslint": "^7.0.0",
5049
"benchmark": "~2.1.0",
5150
"browserify": "^16.1.0",
@@ -60,6 +59,7 @@
6059
"eslint-plugin-import": "^2.9.0",
6160
"eslint-plugin-node": "^5.1.1",
6261
"eslint-plugin-react": "^7.3.0",
62+
"esm": "^3.0.39",
6363
"execcommand-copy": "^1.1.0",
6464
"flow-bin": "^0.69.0",
6565
"flow-coverage-report": "^0.3.0",
@@ -110,11 +110,7 @@
110110
"./src/util/window.js": "./src/util/browser/window.js",
111111
"./src/util/web_worker.js": "./src/util/browser/web_worker.js"
112112
},
113-
"@std/esm": {
114-
"cjs": true,
115-
"esm": "js",
116-
"sourceCache": true
117-
},
113+
"esm": true,
118114
"scripts": {
119115
"build-dev": "rollup -c --environment BUILD:dev",
120116
"watch-dev": "rollup -c --environment BUILD:dev --watch",

src/source/tile_id.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// @flow
22

3-
import WhooTS from '@mapbox/whoots-js';
3+
import {getTileBBox} from '@mapbox/whoots-js';
44

55
import assert from 'assert';
66
import { register } from '../util/web_worker_transfer';
@@ -28,7 +28,7 @@ export class CanonicalTileID {
2828

2929
// given a list of urls, choose a url template and return a tile URL
3030
url(urls: Array<string>, scheme: ?string) {
31-
const bbox = WhooTS.getTileBBox(this.x, this.y, this.z);
31+
const bbox = getTileBBox(this.x, this.y, this.z);
3232
const quadkey = getQuadkey(this.z, this.x, this.y);
3333

3434
return urls[(this.x + this.y) % urls.length]

test/query.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require('./stub_loader');
44
require('@mapbox/flow-remove-types/register');
5-
require = require("@std/esm")(module, true);
5+
require = require("esm")(module, true);
66

77
const querySuite = require('./integration').query;
88
const suiteImplementation = require('./suite_implementation');

test/render.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require('./stub_loader');
44
require('@mapbox/flow-remove-types/register');
5-
require = require("@std/esm")(module, true);
5+
require = require("esm")(module, true);
66

77
const suite = require('./integration').render;
88
const suiteImplementation = require('./suite_implementation');

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,6 @@
239239
version "0.7.0"
240240
resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.7.0.tgz#9a06f4f137ee84d7df0460c1fdb1135ffa6c50fd"
241241

242-
"@std/esm@^0.21.7":
243-
version "0.21.7"
244-
resolved "https://registry.yarnpkg.com/@std/esm/-/esm-0.21.7.tgz#492d7931aed03e91a133deac4d9062fbfce5fd6b"
245-
246242
"@types/acorn@^4.0.3":
247243
version "4.0.3"
248244
resolved "https://registry.yarnpkg.com/@types/acorn/-/acorn-4.0.3.tgz#d1f3e738dde52536f9aad3d3380d14e448820afd"
@@ -3791,6 +3787,10 @@ [email protected]:
37913787
table "^4.0.1"
37923788
text-table "~0.2.0"
37933789

3790+
esm@^3.0.39:
3791+
version "3.0.39"
3792+
resolved "https://registry.yarnpkg.com/esm/-/esm-3.0.39.tgz#076e6a2f846bb579e0b82c494091a0687b494b48"
3793+
37943794
espree@^3.4.3:
37953795
version "3.5.3"
37963796
resolved "https://registry.yarnpkg.com/espree/-/espree-3.5.3.tgz#931e0af64e7fbbed26b050a29daad1fc64799fa6"

0 commit comments

Comments
 (0)