-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindata prefix #3
Comments
i suppose worth noting that the actual interface provided by the generated files is stable. it's just that they aren't going to be identical so each re-generation by different machines / versions of the library will result in re-commits / maybe worth having in .gitignore or find ways to more fully specify the generated output |
Are you using this go-bindata fork: github.com/shuLhan/go-bindata? The original go-bindata is abandonware and there are various unresolved bugs. |
That seems like a great argument for vendoring the specific version of the library we want to include. |
and yes. I am using the shuLhan version. The version that installed for me was at eb5746d, a few commits past v3.3.0 |
the bindata command specified in
makefile
will name the data constants with a prefix. an example is:bindataDataMigrations1createmsmtresultssqlBytes()
However the current calls don't use this prefix, and refer to
dataMigrations1_create_msmt_resultsSqlBytes()
The
-prefix ''
flag can be used to remove the 'bindata' prefix appended by the makefile variant. i don't see how to re-add the '_'sMore generally though, it seems there may be an issue with stable naming from this library / current process.
The text was updated successfully, but these errors were encountered: