Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface DNS failures as unexpected results #904

Open
fortuna opened this issue Jan 12, 2024 · 0 comments
Open

Surface DNS failures as unexpected results #904

fortuna opened this issue Jan 12, 2024 · 0 comments
Labels
triage This issue needs triage

Comments

@fortuna
Copy link

fortuna commented Jan 12, 2024

When the DNS server returns SERVFAIL, which is the predominant interference by CANTV in Venezuela, OONI says the test failed. Example: https://explorer.ooni.org/m/20231227230204.056784_VE_webconnectivity_f12c60cdf02a28ae

image

The errors surfaced in the DNS Queries are very helpful in diagnosing the problem, but it is extra work. That means I can't trust failed measurements and I have to dig manually deeper. The fact that MAT shows up as mostly gray (it could be showing "DNS: Servfail" instead), reduces its value, since I need to check the entries.

The measurement search, when you restrict to CANTV, is misleading, not showing the DNS interference, since failed measurements are omitted by default: https://explorer.ooni.org/search?since=2023-11-28&until=2023-12-29&failure=false&domain=psiphon.ca&probe_cc=VE&probe_asn=AS8048.

My proposed fix here is to treat all DNS measurements using the system resolver as valid, regardless of the error. At a minimum consider any error that indicates a server response as a valid measurement.

@jbonisteel jbonisteel added the triage This issue needs triage label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage This issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants